From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: mst@redhat.com, jasowang@redhat.com, eperezma@redhat.com,
xuanzhuo@linux.alibaba.com, kvm@vger.kernel.org,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vhost: vringh: Remove unused functions
Date: Mon, 16 Jun 2025 14:15:48 +0100 [thread overview]
Message-ID: <20250616131548.GB4750@horms.kernel.org> (raw)
In-Reply-To: <20250613230731.573512-3-linux@treblig.org>
On Sat, Jun 14, 2025 at 12:07:31AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The functions:
> vringh_abandon_kern()
> vringh_abandon_user()
> vringh_iov_pull_kern() and
> vringh_iov_push_kern()
> were all added in 2013 by
> commit f87d0fbb5798 ("vringh: host-side implementation of virtio rings.")
> but have remained unused.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi David,
With this patch (set) applied vlang flags the following.
So I guess that xfer_kern can be removed too.
.../vringh.c:887:19: warning: unused function 'xfer_kern' [-Wunused-function]
887 | static inline int xfer_kern(const struct vringh *vrh, void *src,
| ^~~~~~~~~
.../vringh.c:894:19: warning: unused function 'kern_xfer' [-Wunused-function]
894 | static inline int kern_xfer(const struct vringh *vrh, void *dst,
| ^~~~~~~~~
Otherwise this looks good to me.
next prev parent reply other threads:[~2025-06-16 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 23:07 [PATCH 0/2] vringh small unused functions linux
2025-06-13 23:07 ` [PATCH 1/2] vhost: vringh: Remove unused iotlb functions linux
2025-06-16 13:16 ` Simon Horman
2025-06-13 23:07 ` [PATCH 2/2] vhost: vringh: Remove unused functions linux
2025-06-16 13:15 ` Simon Horman [this message]
2025-06-16 13:33 ` Dr. David Alan Gilbert
2025-06-17 0:19 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616131548.GB4750@horms.kernel.org \
--to=horms@kernel.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).