Re: [net-next PATCH v2 3/6] fbnic: Replace 'link_mode' with 'aui'

[Simon Horman <horms@kernel.org>]

On Thu, Jun 12, 2025 at 08:08:40AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
> 
> The way we were using "link_mode" really was more to describe the
> interface between the attachment unit interface(s) we were using on the
> device. Specifically the AUI is describing the modulation and the number of
> lanes we are using. So we can simplify this by replacing link_mode with
> aui.
> 
> In addition this change makes it so that the enum we use for the FW values
> represents actual link modes that will be normally advertised by a link
> partner. The general idea is to look at using this to populate
> lp_advertising in the future so that we don't have to force the value and
> can instead default to autoneg allowing the user to change it should they
> want to force the link down or are doing some sort of manufacturing test
> with a loopback plug.
> 
> Lastly we make the transition from fw_settings to aui/fec a one time thing
> during phylink_init. The general idea is when we start phylink we should no
> longer update the setting based on the FW and instead only allow the user
> to provide the settings.
> 
> Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>

Hi Alexander,

This patch is doing a lot - I count 3 things.
Could you try and break it up a bit in v3?