* [net] Octeontx2-pf: Fix Backpresure configuration
@ 2025-06-17 6:34 Hariprasad Kelam
2025-06-17 11:27 ` Simon Horman
2025-06-18 21:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hariprasad Kelam @ 2025-06-17 6:34 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Hariprasad Kelam, Sunil Goutham, Geetha sowjanya,
Subbaraya Sundeep, Bharat Bhushan, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
NIX block can receive packets from multiple links such as
MAC (RPM), LBK and CPT.
-----------------
RPM --| NIX |
-----------------
|
|
LBK
Each link supports multiple channels for example RPM link supports
16 channels. In case of link oversubsribe, NIX will assert backpressure
on receive channels.
The previous patch considered a single channel per link, resulting in
backpressure not being enabled on the remaining channels
Fixes: a7ef63dbd588 ("octeontx2-af: Disable backpressure between CPT and NIX")
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 6f572589f1e5..6b5c9536d26d 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1822,7 +1822,7 @@ int otx2_nix_config_bp(struct otx2_nic *pfvf, bool enable)
req->chan_cnt = IEEE_8021QAZ_MAX_TCS;
req->bpid_per_chan = 1;
} else {
- req->chan_cnt = 1;
+ req->chan_cnt = pfvf->hw.rx_chan_cnt;
req->bpid_per_chan = 0;
}
@@ -1847,7 +1847,7 @@ int otx2_nix_cpt_config_bp(struct otx2_nic *pfvf, bool enable)
req->chan_cnt = IEEE_8021QAZ_MAX_TCS;
req->bpid_per_chan = 1;
} else {
- req->chan_cnt = 1;
+ req->chan_cnt = pfvf->hw.rx_chan_cnt;
req->bpid_per_chan = 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net] Octeontx2-pf: Fix Backpresure configuration
2025-06-17 6:34 [net] Octeontx2-pf: Fix Backpresure configuration Hariprasad Kelam
@ 2025-06-17 11:27 ` Simon Horman
2025-06-18 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-06-17 11:27 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: netdev, linux-kernel, Sunil Goutham, Geetha sowjanya,
Subbaraya Sundeep, Bharat Bhushan, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Tue, Jun 17, 2025 at 12:04:02PM +0530, Hariprasad Kelam wrote:
> NIX block can receive packets from multiple links such as
> MAC (RPM), LBK and CPT.
>
> -----------------
> RPM --| NIX |
> -----------------
> |
> |
> LBK
>
> Each link supports multiple channels for example RPM link supports
> 16 channels. In case of link oversubsribe, NIX will assert backpressure
> on receive channels.
>
> The previous patch considered a single channel per link, resulting in
> backpressure not being enabled on the remaining channels
>
> Fixes: a7ef63dbd588 ("octeontx2-af: Disable backpressure between CPT and NIX")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net] Octeontx2-pf: Fix Backpresure configuration
2025-06-17 6:34 [net] Octeontx2-pf: Fix Backpresure configuration Hariprasad Kelam
2025-06-17 11:27 ` Simon Horman
@ 2025-06-18 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-06-18 21:30 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: netdev, linux-kernel, sgoutham, gakula, sbhatta, bbhushan2,
andrew+netdev, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 17 Jun 2025 12:04:02 +0530 you wrote:
> NIX block can receive packets from multiple links such as
> MAC (RPM), LBK and CPT.
>
> -----------------
> RPM --| NIX |
> -----------------
> |
> |
> LBK
>
> [...]
Here is the summary with links:
- [net] Octeontx2-pf: Fix Backpresure configuration
https://git.kernel.org/netdev/net/c/9ac8d0c640a1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-18 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 6:34 [net] Octeontx2-pf: Fix Backpresure configuration Hariprasad Kelam
2025-06-17 11:27 ` Simon Horman
2025-06-18 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).