[PATCH net-next v1] net/mlx4e: Don't redefine IB_MTU_XXX enum

[PATCH net-next v1] net/mlx4e: Don't redefine IB_MTU_XXX enum

[Leon Romanovsky]

From: Mark Zhang <markzhang@nvidia.com>

Rely on existing IB_MTU_XXX definitions which exist in ib_verbs.h.

Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
Signed-off-by: Mark Zhang <markzhang@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
Changelog:
v1:
 * Change target from net to be net-next
 * Rewrote commit message
 * Removed Fixes line
v0: https://lore.kernel.org/all/aca9b2c482b4bea91e3750b15b2b00a33ee0265a.1750062150.git.leon@kernel.org
---
 drivers/net/ethernet/mellanox/mlx4/main.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index febeadfdd5a5..03d2fc7d9b09 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -49,6 +49,8 @@
 #include <linux/mlx4/device.h>
 #include <linux/mlx4/doorbell.h>
 
+#include <rdma/ib_verbs.h>
+
 #include "mlx4.h"
 #include "fw.h"
 #include "icm.h"
@@ -1246,14 +1248,6 @@ static ssize_t set_port_type(struct device *dev,
 	return err ? err : count;
 }
 
-enum ibta_mtu {
-	IB_MTU_256  = 1,
-	IB_MTU_512  = 2,
-	IB_MTU_1024 = 3,
-	IB_MTU_2048 = 4,
-	IB_MTU_4096 = 5
-};
-
 static inline int int_to_ibta_mtu(int mtu)
 {
 	switch (mtu) {
@@ -1266,7 +1260,7 @@ static inline int int_to_ibta_mtu(int mtu)
 	}
 }
 
-static inline int ibta_mtu_to_int(enum ibta_mtu mtu)
+static inline int ibta_mtu_to_int(enum ib_mtu mtu)
 {
 	switch (mtu) {
 	case IB_MTU_256:  return  256;
-- 
2.49.0

Re: [PATCH net-next v1] net/mlx4e: Don't redefine IB_MTU_XXX enum

[Simon Horman]

On Tue, Jun 17, 2025 at 11:06:30AM +0300, Leon Romanovsky wrote:
> From: Mark Zhang <markzhang@nvidia.com>
> 
> Rely on existing IB_MTU_XXX definitions which exist in ib_verbs.h.
> 
> Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> Changelog:
> v1:
>  * Change target from net to be net-next
>  * Rewrote commit message
>  * Removed Fixes line
> v0: https://lore.kernel.org/all/aca9b2c482b4bea91e3750b15b2b00a33ee0265a.1750062150.git.leon@kernel.org

Thanks for the update.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next v1] net/mlx4e: Don't redefine IB_MTU_XXX enum

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 17 Jun 2025 11:06:30 +0300 you wrote:
> From: Mark Zhang <markzhang@nvidia.com>
> 
> Rely on existing IB_MTU_XXX definitions which exist in ib_verbs.h.
> 
> Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v1] net/mlx4e: Don't redefine IB_MTU_XXX enum
    https://git.kernel.org/netdev/net-next/c/e0e3265acf5a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html