From: David Wei <dw@davidwei.uk>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>
Subject: [PATCH net v2 0/4] net: fix passive TFO socket having invalid NAPI ID
Date: Tue, 17 Jun 2025 14:20:58 -0700 [thread overview]
Message-ID: <20250617212102.175711-1-dw@davidwei.uk> (raw)
Found a bug where an accepted passive TFO socket returns an invalid NAPI
ID (i.e. 0) from SO_INCOMING_NAPI_ID. Add a selftest for this using
netdevsim and fix the bug.
Patch 1 is a drive-by fix for the lib.sh include in an existing
drivers/net/netdevsim/peer.sh selftest.
Patch 2 adds a test binary for a simple TFO server/client.
Patch 3 adds a selftest for checking that the NAPI ID of a passive TFO
socket is valid. This will currently fail.
Patch 4 adds a fix for the bug.
Changes in v2:
--------------
* Use sk_mark_napi_id_set() instead
* Add fixes tag to patch 4
David Wei (4):
selftests: netdevsim: improve lib.sh include in peer.sh
selftests: net: add passive TFO test binary
selftests: net: add test for passive TFO socket NAPI ID
tcp: fix passive TFO socket having invalid NAPI ID
net/ipv4/tcp_fastopen.c | 3 +
.../selftests/drivers/net/netdevsim/peer.sh | 3 +-
tools/testing/selftests/net/.gitignore | 1 +
tools/testing/selftests/net/Makefile | 2 +
tools/testing/selftests/net/tfo.c | 171 ++++++++++++++++++
tools/testing/selftests/net/tfo_passive.sh | 112 ++++++++++++
6 files changed, 291 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/net/tfo.c
create mode 100755 tools/testing/selftests/net/tfo_passive.sh
--
2.47.1
next reply other threads:[~2025-06-17 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 21:20 David Wei [this message]
2025-06-17 21:20 ` [PATCH net v2 1/4] selftests: netdevsim: improve lib.sh include in peer.sh David Wei
2025-06-17 21:21 ` [PATCH net v2 2/4] selftests: net: add passive TFO test binary David Wei
2025-06-17 21:21 ` [PATCH net v2 3/4] selftests: net: add test for passive TFO socket NAPI ID David Wei
2025-06-17 21:21 ` [PATCH net v2 4/4] tcp: fix passive TFO socket having invalid " David Wei
2025-06-17 21:29 ` Kuniyuki Iwashima
2025-06-18 8:11 ` Eric Dumazet
2025-06-19 2:20 ` [PATCH net v2 0/4] net: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617212102.175711-1-dw@davidwei.uk \
--to=dw@davidwei.uk \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).