From: Simon Horman <horms@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net-next: gianfar: Use device_get_named_child_node_count()
Date: Wed, 18 Jun 2025 11:42:51 +0100 [thread overview]
Message-ID: <20250618104251.GD1699@horms.kernel.org> (raw)
In-Reply-To: <aFFVvjM4Dho863x2@black.fi.intel.com>
On Tue, Jun 17, 2025 at 02:47:10PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 17, 2025 at 01:58:26PM +0300, Matti Vaittinen wrote:
> > We can avoid open-coding the loop construct which counts firmware child
> > nodes with a specific name by using the newly added
> > device_get_named_child_node_count().
> >
> > The gianfar driver has such open-coded loop. Replace it with the
> > device_get_child_node_count_named().
>
> Just a side note: The net-next is assumed to be in the square brackets, so when
> you format patch, use something like
>
> git format-patch --subject-prefix="PATCH, net-next" ...
Hi Matti,
It looks like this patch has been marked as Changes Requested in patchwork.
I assume because of Andy's comment above.
Could you address that and submit a v2?
Subject: [PATCH net-next v2] ...
Otherwise, this looks good to me.
next prev parent reply other threads:[~2025-06-18 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 10:58 [PATCH] net-next: gianfar: Use device_get_named_child_node_count() Matti Vaittinen
2025-06-17 11:47 ` Andy Shevchenko
2025-06-18 10:42 ` Simon Horman [this message]
2025-06-18 12:20 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618104251.GD1699@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).