From: Jakub Kicinski <kuba@kernel.org>
To: Sharath Chandra Vurukala <quic_sharathv@quicinc.com>
Cc: <Jason@zx2c4.com>, <wireguard@lists.zx2c4.com>, <netdev@vger.kernel.org>
Subject: Re: Issue with rtnl_lock in wg_pm_notification
Date: Wed, 18 Jun 2025 11:47:35 -0700 [thread overview]
Message-ID: <20250618114735.5472f2cd@kernel.org> (raw)
In-Reply-To: <2c5257a7-e330-4983-8447-3e217b616b2e@quicinc.com>
On Tue, 17 Jun 2025 01:44:56 +0530 Sharath Chandra Vurukala wrote:
> I do not understand fully what wireguard functionality is, but
> considering that rtnl_lock is a global one, it does not seem to be a
> good design to have notification callback acquire this lock.
I'm not very familiar with the PM locks, but isn't the PM notification
lock also a global one? Again, not an expert but having PM lock outside
the rtnl_lock would be more intuitive to me.
prev parent reply other threads:[~2025-06-18 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 20:14 Issue with rtnl_lock in wg_pm_notification Sharath Chandra Vurukala
2025-06-18 18:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618114735.5472f2cd@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=netdev@vger.kernel.org \
--cc=quic_sharathv@quicinc.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).