From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, lee@trager.us,
jacob.e.keller@intel.com, Alexander Duyck <alexanderduyck@fb.com>
Subject: Re: [PATCH net] eth: fbnic: avoid double free when failing to DMA-map FW msg
Date: Thu, 19 Jun 2025 07:10:04 -0700 [thread overview]
Message-ID: <20250619071004.5e841f1a@kernel.org> (raw)
In-Reply-To: <9ed6bff1-9210-4b2d-a897-2321316ac3b9@redhat.com>
On Thu, 19 Jun 2025 12:18:58 +0200 Paolo Abeni wrote:
> On 6/16/25 9:55 PM, Jakub Kicinski wrote:
> > The semantics are that caller of fbnic_mbx_map_msg() retains
> > the ownership of the message on error.
>
> FWIW, I think the opposite semantic would lead to simpler/smaller code
> overall, but no objections to retain the current one.
Interesting, I'd have thought the semantics of "on error caller retains
the ownership of the object they are trying to hand over" are generally
considered more intuitive.
next prev parent reply other threads:[~2025-06-19 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 19:55 [PATCH net] eth: fbnic: avoid double free when failing to DMA-map FW msg Jakub Kicinski
2025-06-16 20:47 ` Keller, Jacob E
2025-06-19 10:18 ` Paolo Abeni
2025-06-19 14:10 ` Jakub Kicinski [this message]
2025-06-19 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619071004.5e841f1a@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=lee@trager.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).