[PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[Kory Maincent]

Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
build warning reported by the kernel test robot.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 net/ethtool/pse-pd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ethtool/pse-pd.c b/net/ethtool/pse-pd.c
index 6c536dfe52da..24def9c9dd54 100644
--- a/net/ethtool/pse-pd.c
+++ b/net/ethtool/pse-pd.c
@@ -11,6 +11,7 @@
 #include "netlink.h"
 #include <linux/ethtool_netlink.h>
 #include <linux/ethtool.h>
+#include <linux/export.h>
 #include <linux/phy.h>
 
 struct pse_req_info {
-- 
2.43.0

Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[Simon Horman]

On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> build warning reported by the kernel test robot.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Hi Kory, all,

The change that introduced this warning introduced a log of such warnings.
Including a lot in the Networking subsystem. (I did not count them.)

So I agree with the point from Sean Christopherson [*] is that if the patch
that introduced the warnings isn't reverted then a more comprehensive
approach is needed to address these warnings.

[*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
    https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/

Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[Kory Maincent]

Le Fri, 20 Jun 2025 11:14:52 +0100,
Simon Horman <horms@kernel.org> a écrit :

> On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> > Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> > build warning reported by the kernel test robot.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> 
> Hi Kory, all,
> 
> The change that introduced this warning introduced a log of such warnings.
> Including a lot in the Networking subsystem. (I did not count them.)
> 
> So I agree with the point from Sean Christopherson [*] is that if the patch
> that introduced the warnings isn't reverted then a more comprehensive
> approach is needed to address these warnings.
> 
> [*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h
> header inclusion https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/

Ok, thanks for the info.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[Jakub Kicinski]

On Fri, 20 Jun 2025 11:14:52 +0100 Simon Horman wrote:
> On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> > Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> > build warning reported by the kernel test robot.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> 
> The change that introduced this warning introduced a log of such warnings.
> Including a lot in the Networking subsystem. (I did not count them.)
> 
> So I agree with the point from Sean Christopherson [*] is that if the patch
> that introduced the warnings isn't reverted

It was reverted, thankfully. So I assume we treat this patch as 
a normal "include what you need" case and therefore apply.. ?

> then a more comprehensive approach is needed to address these warnings.
> 
> [*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
>     https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/

Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 19 Jun 2025 18:25:47 +0200 you wrote:
> Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> build warning reported by the kernel test robot.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> 
> [...]

Here is the summary with links:
  - [net-next] ethtool: pse-pd: Add missing linux/export.h include
    https://git.kernel.org/netdev/net-next/c/96c16c59b705

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html