From: Jakub Kicinski <kuba@kernel.org>
To: willemb@google.com, Joe Damato <joe@dama.to>
Cc: Samiullah Khawaja <skhawaja@google.com>,
"David S . Miller " <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
almasrymina@google.com, mkarsten@uwaterloo.ca,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v9] Add support to set NAPI threaded for individual NAPI
Date: Tue, 24 Jun 2025 16:50:39 -0700 [thread overview]
Message-ID: <20250624165039.5bf4b3d9@kernel.org> (raw)
In-Reply-To: <20250623175316.2034885-1-skhawaja@google.com>
[swapping Joe's email for a working one]
On Mon, 23 Jun 2025 17:53:16 +0000 Samiullah Khawaja wrote:
> A net device has a threaded sysctl that can be used to enable threaded
> NAPI polling on all of the NAPI contexts under that device. Allow
> enabling threaded NAPI polling at individual NAPI level using netlink.
>
> Extend the netlink operation `napi-set` and allow setting the threaded
> attribute of a NAPI. This will enable the threaded polling on a NAPI
> context.
>
> Add a test in `nl_netdev.py` that verifies various cases of threaded
> NAPI being set at NAPI and at device level.
LGTM, but as we discussed many version ago my subjective preference
would be for the per-queue setting to be tri-state (unset=follow the
device setting, enabled, disabled). Rather than have the device level
act as an override when written. It sounded like Willem and Joe thought
that's too complicated and diverges from the existing behavior.
Which is fine by me. But I'd like to see some review tags from them
now :)
Gentlemen?
next prev parent reply other threads:[~2025-06-24 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 17:53 [PATCH net-next v9] Add support to set NAPI threaded for individual NAPI Samiullah Khawaja
2025-06-24 23:50 ` Jakub Kicinski [this message]
2025-07-09 22:15 ` Willem de Bruijn
2025-06-25 1:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624165039.5bf4b3d9@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joe@dama.to \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).