[PATCH] uapi: net_dropmon: drop unused is_drop_point_hw macro

[PATCH] uapi: net_dropmon: drop unused is_drop_point_hw macro

[RubenKelevra]

Commit 4ea7e38696c7 ("dropmon: add ability to detect when hardware
drops rx packets") introduced is_drop_point_hw, but the symbol was
never referenced anywhere in the kernel tree and is currently not used
by dropwatch. I could not find, to the best of my abilities, a current
out-of-tree user of this macro.

The definition also contains a syntax error in its for-loop, so any
project that tried to compile against it would fail. Removing the
macro therefore eliminates dead code without breaking existing
users.

Fixes: 4ea7e38696c7e ("dropmon: add ability to detect when hardware dropsrxpackets")
Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
---
 include/uapi/linux/net_dropmon.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/uapi/linux/net_dropmon.h b/include/uapi/linux/net_dropmon.h
index 9dd41c2f58a6..87cbef48d4c7 100644
--- a/include/uapi/linux/net_dropmon.h
+++ b/include/uapi/linux/net_dropmon.h
@@ -10,13 +10,6 @@ struct net_dm_drop_point {
 	__u32 count;
 };
 
-#define is_drop_point_hw(x) do {\
-	int ____i, ____j;\
-	for (____i = 0; ____i < 8; i ____i++)\
-		____j |= x[____i];\
-	____j;\
-} while (0)
-
 #define NET_DM_CFG_VERSION  0
 #define NET_DM_CFG_ALERT_COUNT  1
 #define NET_DM_CFG_ALERT_DELAY 2
-- 
2.50.0

Re: [PATCH] uapi: net_dropmon: drop unused is_drop_point_hw macro

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 24 Jun 2025 18:57:11 +0200 you wrote:
> Commit 4ea7e38696c7 ("dropmon: add ability to detect when hardware
> drops rx packets") introduced is_drop_point_hw, but the symbol was
> never referenced anywhere in the kernel tree and is currently not used
> by dropwatch. I could not find, to the best of my abilities, a current
> out-of-tree user of this macro.
> 
> The definition also contains a syntax error in its for-loop, so any
> project that tried to compile against it would fail. Removing the
> macro therefore eliminates dead code without breaking existing
> users.
> 
> [...]

Here is the summary with links:
  - uapi: net_dropmon: drop unused is_drop_point_hw macro
    https://git.kernel.org/netdev/net-next/c/2855e43c6bb1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html