* [PATCH] [net] net: thunderbolt: Use correct request type in login/logout request packets
@ 2025-06-25 6:30 zhangjianrong
2025-06-25 6:41 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: zhangjianrong @ 2025-06-25 6:30 UTC (permalink / raw)
To: michael.jamet, mika.westerberg, YehezkelShB, andrew+netdev, davem,
edumazet, kuba, pabeni, netdev, linux-kernel
Cc: guhengsheng, caiyadong, xuetao09, lixinghang1
It doesn't make sense to use TB_CFG_PKG_XDOMAIN_RESP as the request
type of xdomain request packets.
Signed-off-by: zhangjianrong <zhangjianrong5@huawei.com>
---
drivers/net/thunderbolt/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c
index 0a53ec293d04..439d1b21f3b7 100644
--- a/drivers/net/thunderbolt/main.c
+++ b/drivers/net/thunderbolt/main.c
@@ -269,7 +269,7 @@ static int tbnet_login_request(struct tbnet *net, u8 sequence)
request.transmit_path = net->local_transmit_path;
return tb_xdomain_request(xd, &request, sizeof(request),
- TB_CFG_PKG_XDOMAIN_RESP, &reply,
+ TB_CFG_PKG_XDOMAIN_REQ, &reply,
sizeof(reply), TB_CFG_PKG_XDOMAIN_RESP,
TBNET_LOGIN_TIMEOUT);
}
@@ -300,7 +300,7 @@ static int tbnet_logout_request(struct tbnet *net)
atomic_inc_return(&net->command_id));
return tb_xdomain_request(xd, &request, sizeof(request),
- TB_CFG_PKG_XDOMAIN_RESP, &reply,
+ TB_CFG_PKG_XDOMAIN_REQ, &reply,
sizeof(reply), TB_CFG_PKG_XDOMAIN_RESP,
TBNET_LOGOUT_TIMEOUT);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net] net: thunderbolt: Use correct request type in login/logout request packets
2025-06-25 6:30 [PATCH] [net] net: thunderbolt: Use correct request type in login/logout request packets zhangjianrong
@ 2025-06-25 6:41 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2025-06-25 6:41 UTC (permalink / raw)
To: zhangjianrong
Cc: michael.jamet, YehezkelShB, andrew+netdev, davem, edumazet, kuba,
pabeni, netdev, linux-kernel, guhengsheng, caiyadong, xuetao09,
lixinghang1
On Wed, Jun 25, 2025 at 02:30:48PM +0800, zhangjianrong wrote:
> It doesn't make sense to use TB_CFG_PKG_XDOMAIN_RESP as the request
> type of xdomain request packets.
Same here as with previous. It is RESP on purpose.
Did you try this patch?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-25 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-25 6:30 [PATCH] [net] net: thunderbolt: Use correct request type in login/logout request packets zhangjianrong
2025-06-25 6:41 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).