From: Simon Horman <horms@kernel.org>
To: Michal Luczaj <mhal@rbox.co>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
David Ahern <dsahern@kernel.org>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/7] net: splice: Drop nr_pages_max initialization
Date: Wed, 25 Jun 2025 11:06:10 +0100 [thread overview]
Message-ID: <20250625100610.GO1562@horms.kernel.org> (raw)
In-Reply-To: <20250624-splice-drop-unused-v1-6-cf641a676d04@rbox.co>
On Tue, Jun 24, 2025 at 11:53:53AM +0200, Michal Luczaj wrote:
> splice_pipe_desc::nr_pages_max was initialized unnecessary in commit
> 41c73a0d44c9 ("net: speedup skb_splice_bits()"). spd_fill_page() compares
> spd->nr_pages against a constant MAX_SKB_FRAGS, which makes setting
> nr_pages_max redundant.
>
> Remove the assignment. No functional change intended.
>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> Probably the same thing in net/smc/smc_rx.c:smc_rx_splice()?
Yes, it seems so to me.
next prev parent reply other threads:[~2025-06-25 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 9:53 [PATCH net-next 0/7] net: Remove unused function parameters in skbuff.c Michal Luczaj
2025-06-24 9:53 ` [PATCH net-next 1/7] net: splice: Drop unused @pipe Michal Luczaj
2025-06-25 10:07 ` Simon Horman
2025-06-24 9:53 ` [PATCH net-next 2/7] net: splice: Drop unused @flags Michal Luczaj
2025-06-25 10:06 ` Simon Horman
2025-06-24 9:53 ` [PATCH net-next 3/7] tcp: Drop tcp_splice_state::flags Michal Luczaj
2025-06-25 10:06 ` Simon Horman
2025-06-24 9:53 ` [PATCH net-next 4/7] af_unix: Drop unix_stream_read_state::splice_flags Michal Luczaj
2025-06-25 10:06 ` Simon Horman
2025-06-24 9:53 ` [PATCH net-next 5/7] net: splice: Drop unused @gfp Michal Luczaj
2025-06-25 10:07 ` Simon Horman
2025-06-24 9:53 ` [PATCH net-next 6/7] net: splice: Drop nr_pages_max initialization Michal Luczaj
2025-06-25 10:06 ` Simon Horman [this message]
2025-06-25 21:43 ` Michal Luczaj
2025-06-24 9:53 ` [PATCH net-next 7/7] net: skbuff: Drop unused @skb Michal Luczaj
2025-06-25 10:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625100610.GO1562@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ayush.sawal@chelsio.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).