From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2126F2DCBE0; Wed, 25 Jun 2025 20:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750883546; cv=none; b=dlqrblIqXpT1XJ57AfVogyUApxb1ot3h+uo1yYv+qOKurumHGG6jlugg6XDuBXqUFJsEWJ0IjXbhvIS/KxmanK/VJZtG7ASYpucUHUoLeUEIw048LNrW7Li2bINP7E9vX2dyiKu0SxYitqx43qPzgxtGvct1JmsUy4+b2jX9dr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750883546; c=relaxed/simple; bh=eBcB7YwafvAo6c7n0ddMbuEerxCNn+CDq/Kw5dtgJA8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qCqj8ho1n0YRZLWmcrJsypATN05xeJCXJDLmB6gbX0W3EZGRGOep9Tl5xhVxezYRuXJPHSohYJQAMgsWB8Wk+sbdOenr3bXBv1nygdeiuzTxm3R5URw7GyS0kUg7ty1on5BCU32SR6GIdhvM1xA+vGJEdPoOmYGwxJtsowhlWfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BOMBS7z/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BOMBS7z/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 602C5C4CEEA; Wed, 25 Jun 2025 20:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750883545; bh=eBcB7YwafvAo6c7n0ddMbuEerxCNn+CDq/Kw5dtgJA8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BOMBS7z/NGKl9x0n9QzHFzC8ppAC+6Yinyu+c1fVfcvmwwW7DKr/qg0QoAi8wySJ6 C+9R8OAk5WCpqTRyuARcBSqx1lMNpuoon6TVPLqKVLnIqf5k8kqvHrLZf1rqYtPHXQ a/qDTR6RteviS2KBSNWHwbexlzW/CUBzJ55OBOOk/uHEox4zldChDjfd/hNuORqomw vnDN7p60z+0Qb1KCcnpg3suuLMcfVF3KOYDjKzcNpJI1BCZPR5TxnkiJXvL/ALqsI0 mMyucGTqUzPUc0e2CfYFV5yIPSIXdOFKjPoe+VH626WhnpdlR1sEag8e0cecRJHzlP GYdKyvAHs/r4Q== Date: Wed, 25 Jun 2025 13:32:24 -0700 From: Jakub Kicinski To: Simon Horman Cc: Wei Fang , Claudiu Manoil , Vladimir Oltean , Clark Wang , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" Subject: Re: [PATCH v2 net-next 0/3] change some statistics to 64-bit Message-ID: <20250625133224.275a8635@kernel.org> In-Reply-To: <20250625163459.GD152961@horms.kernel.org> References: <20250624101548.2669522-1-wei.fang@nxp.com> <20250624181143.6206a518@kernel.org> <20250625163459.GD152961@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Jun 2025 17:34:59 +0100 Simon Horman wrote: > > Simon has posted a patch [1] to fix the sparse warnings. Do I need to wait until > > Simon's patch is applied to the net-next tree and then resend this patch set? > > > > [1] https://lore.kernel.org/imx/20250624-etnetc-le-v1-1-a73a95d96e4e@kernel.org/ > > Yes, I have confirmed that with patch[1] applied this patch-set > does not introduce any Sparse warnings (in my environment). > > I noticed the Sparse warnings that are otherwise introduced when reviewing > v1 of this patchset which is why I crated patch[1]. > > The issue is that there is are long standing Sparse warnings - which > highlight a driver bug, albeit one that doesn't manifest with in tree > users. They is due to an unnecessary call to le64_to_cpu(). The warnings > are: > > .../enetc_hw.h:513:16: warning: cast to restricted __le64 > .../enetc_hw.h:513:16: warning: restricted __le64 degrades to integer > .../enetc_hw.h:513:16: warning: cast to restricted __le64 > > Patches 2/3 and 3/3 multiply the incidence of the above 3 warnings because > they increase the callers of the inline function where the problem lies. > > But I'd argue that, other than noise, they don't make things worse. > The bug doesn't manifest for in-tree users (and if it did, it would > have been manifesting anyway). > > So I'd advocate accepting this series (or not) independent of resolving > the Sparse warnings. Which should disappear when patch[1], or some variant > thereof, is accepted (via net or directly into net-next). All fair points, but unfortunately if there is a build issue the patches are not fed into the full CI cycle. Simon's fix will hit net-next tomorrow, let's get these reposted tomorrow so we can avoid any (unlikely) surprises?