[PATCH rdma-next 0/2] Add multiple priorities support to mlx5 RDMA TRANSPORT tables

[PATCH rdma-next 0/2] Add multiple priorities support to mlx5 RDMA TRANSPORT tables

[Leon Romanovsky]

Hi,

This short series from Patrisious extends mlx5 flow steering logic to
allow creation rule creation with priorities in RDMA TRANSPORT tables.

Thanks  

Patrisious Haddad (2):
  net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain
  RDMA/mlx5: Add multiple priorities support to RDMA TRANSPORT userspace
    tables

 drivers/infiniband/hw/mlx5/fs.c               | 40 ++++++++++++-------
 drivers/infiniband/hw/mlx5/fs.h               |  8 +++-
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |  4 +-
 .../net/ethernet/mellanox/mlx5/core/fs_core.c | 30 ++++++++++----
 include/linux/mlx5/fs.h                       |  2 +-
 5 files changed, 56 insertions(+), 28 deletions(-)

-- 
2.49.0

[PATCH mlx5-next 1/2] net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain

[Leon Romanovsky]

From: Patrisious Haddad <phaddad@nvidia.com>

RDMA TRANSPORT domains were initially limited to a single priority.
This change allows the domains to have multiple priorities, making
it possible to add several rules and control the order in which
they're evaluated.

Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 .../net/ethernet/mellanox/mlx5/core/fs_core.c | 30 ++++++++++++++-----
 include/linux/mlx5/fs.h                       |  2 +-
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 23a7e8e7adfa..63b2aa44084b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -3242,34 +3242,48 @@ static int
 init_rdma_transport_rx_root_ns_one(struct mlx5_flow_steering *steering,
 				   int vport_idx)
 {
+	struct mlx5_flow_root_namespace *root_ns;
 	struct fs_prio *prio;
+	int i;
 
 	steering->rdma_transport_rx_root_ns[vport_idx] =
 		create_root_ns(steering, FS_FT_RDMA_TRANSPORT_RX);
 	if (!steering->rdma_transport_rx_root_ns[vport_idx])
 		return -ENOMEM;
 
-	/* create 1 prio*/
-	prio = fs_create_prio(&steering->rdma_transport_rx_root_ns[vport_idx]->ns,
-			      MLX5_RDMA_TRANSPORT_BYPASS_PRIO, 1);
-	return PTR_ERR_OR_ZERO(prio);
+	root_ns = steering->rdma_transport_rx_root_ns[vport_idx];
+
+	for (i = 0; i < MLX5_RDMA_TRANSPORT_BYPASS_PRIO; i++) {
+		prio = fs_create_prio(&root_ns->ns, i, 1);
+		if (IS_ERR(prio))
+			return PTR_ERR(prio);
+	}
+	set_prio_attrs(root_ns);
+	return 0;
 }
 
 static int
 init_rdma_transport_tx_root_ns_one(struct mlx5_flow_steering *steering,
 				   int vport_idx)
 {
+	struct mlx5_flow_root_namespace *root_ns;
 	struct fs_prio *prio;
+	int i;
 
 	steering->rdma_transport_tx_root_ns[vport_idx] =
 		create_root_ns(steering, FS_FT_RDMA_TRANSPORT_TX);
 	if (!steering->rdma_transport_tx_root_ns[vport_idx])
 		return -ENOMEM;
 
-	/* create 1 prio*/
-	prio = fs_create_prio(&steering->rdma_transport_tx_root_ns[vport_idx]->ns,
-			      MLX5_RDMA_TRANSPORT_BYPASS_PRIO, 1);
-	return PTR_ERR_OR_ZERO(prio);
+	root_ns = steering->rdma_transport_tx_root_ns[vport_idx];
+
+	for (i = 0; i < MLX5_RDMA_TRANSPORT_BYPASS_PRIO; i++) {
+		prio = fs_create_prio(&root_ns->ns, i, 1);
+		if (IS_ERR(prio))
+			return PTR_ERR(prio);
+	}
+	set_prio_attrs(root_ns);
+	return 0;
 }
 
 static int init_rdma_transport_rx_root_ns(struct mlx5_flow_steering *steering)
diff --git a/include/linux/mlx5/fs.h b/include/linux/mlx5/fs.h
index 939e58c2f386..86055d55836d 100644
--- a/include/linux/mlx5/fs.h
+++ b/include/linux/mlx5/fs.h
@@ -40,7 +40,7 @@
 
 #define MLX5_SET_CFG(p, f, v) MLX5_SET(create_flow_group_in, p, f, v)
 
-#define MLX5_RDMA_TRANSPORT_BYPASS_PRIO 0
+#define MLX5_RDMA_TRANSPORT_BYPASS_PRIO 16
 #define MLX5_FS_MAX_POOL_SIZE BIT(30)
 
 enum mlx5_flow_destination_type {
-- 
2.49.0

Re: [PATCH rdma-next 0/2] Add multiple priorities support to mlx5 RDMA TRANSPORT tables

[Zhu Yanjun]

在 2025/6/17 1:19, Leon Romanovsky 写道:
> Hi,
> 
> This short series from Patrisious extends mlx5 flow steering logic to
> allow creation rule creation with priorities in RDMA TRANSPORT tables.
         ^^^^^^^^
This "creation" should be removed?

Yanjun.Zhu

> 
> Thanks
> 
> Patrisious Haddad (2):
>    net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain
>    RDMA/mlx5: Add multiple priorities support to RDMA TRANSPORT userspace
>      tables
> 
>   drivers/infiniband/hw/mlx5/fs.c               | 40 ++++++++++++-------
>   drivers/infiniband/hw/mlx5/fs.h               |  8 +++-
>   drivers/infiniband/hw/mlx5/mlx5_ib.h          |  4 +-
>   .../net/ethernet/mellanox/mlx5/core/fs_core.c | 30 ++++++++++----
>   include/linux/mlx5/fs.h                       |  2 +-
>   5 files changed, 56 insertions(+), 28 deletions(-)
> 

Re: [PATCH rdma-next 0/2] Add multiple priorities support to mlx5 RDMA TRANSPORT tables

[Leon Romanovsky]

On Tue, Jun 17, 2025 at 09:53:18PM -0700, Zhu Yanjun wrote:
> 在 2025/6/17 1:19, Leon Romanovsky 写道:
> > Hi,
> > 
> > This short series from Patrisious extends mlx5 flow steering logic to
> > allow creation rule creation with priorities in RDMA TRANSPORT tables.
>         ^^^^^^^^
> This "creation" should be removed?

This is typo on cover letter which is going to be disposed.

Thanks

> 
> Yanjun.Zhu
> 
> > 
> > Thanks
> > 
> > Patrisious Haddad (2):
> >    net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain
> >    RDMA/mlx5: Add multiple priorities support to RDMA TRANSPORT userspace
> >      tables
> > 
> >   drivers/infiniband/hw/mlx5/fs.c               | 40 ++++++++++++-------
> >   drivers/infiniband/hw/mlx5/fs.h               |  8 +++-
> >   drivers/infiniband/hw/mlx5/mlx5_ib.h          |  4 +-
> >   .../net/ethernet/mellanox/mlx5/core/fs_core.c | 30 ++++++++++----
> >   include/linux/mlx5/fs.h                       |  2 +-
> >   5 files changed, 56 insertions(+), 28 deletions(-)
> > 
> 
> 

Re: [PATCH mlx5-next 1/2] net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain

[Jakub Kicinski]

On Tue, 17 Jun 2025 11:19:15 +0300 Leon Romanovsky wrote:
> +	for (i = 0; i < MLX5_RDMA_TRANSPORT_BYPASS_PRIO; i++) {
> +		prio = fs_create_prio(&root_ns->ns, i, 1);
> +		if (IS_ERR(prio))
> +			return PTR_ERR(prio);
> +	}
> +	set_prio_attrs(root_ns);

Looking at the PR now -- y'all sure this doesn't need any extra cleanup
if creation of non-first prio fails?

Re: [PATCH mlx5-next 1/2] net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain

[Leon Romanovsky]

On Wed, Jun 25, 2025 at 04:42:00PM -0700, Jakub Kicinski wrote:
> On Tue, 17 Jun 2025 11:19:15 +0300 Leon Romanovsky wrote:
> > +	for (i = 0; i < MLX5_RDMA_TRANSPORT_BYPASS_PRIO; i++) {
> > +		prio = fs_create_prio(&root_ns->ns, i, 1);
> > +		if (IS_ERR(prio))
> > +			return PTR_ERR(prio);
> > +	}
> > +	set_prio_attrs(root_ns);
> 
> Looking at the PR now -- y'all sure this doesn't need any extra cleanup
> if creation of non-first prio fails?

Yes, it was missed.

Thanks