From: Simon Horman <horms@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Sai Krishna <saikrishnag@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] octeontx2-af: Fix error code in rvu_mbox_init()
Date: Thu, 26 Jun 2025 10:13:12 +0100 [thread overview]
Message-ID: <20250626091312.GV1562@horms.kernel.org> (raw)
In-Reply-To: <aFzp70LaPoO0ukw8@822c91e11a5c>
On Thu, Jun 26, 2025 at 06:34:23AM +0000, Subbaraya Sundeep wrote:
> On 2025-06-25 at 15:23:05, Dan Carpenter (dan.carpenter@linaro.org) wrote:
> > The error code was intended to be -EINVAL here, but it was accidentally
> > changed to returning success. Set the error code.
> >
> > Fixes: e53ee4acb220 ("octeontx2-af: CN20k basic mbox operations and structures")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
>
> Thanks for the patch. This has been pointed by Simon earlier:
> https://lore.kernel.org/all/20250618194301.GA1699@horms.kernel.org/
Thanks for the fix.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-26 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 15:23 [PATCH net-next] octeontx2-af: Fix error code in rvu_mbox_init() Dan Carpenter
2025-06-26 6:34 ` Subbaraya Sundeep
2025-06-26 9:13 ` Simon Horman [this message]
2025-06-29 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626091312.GV1562@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).