From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Geurts <paul.geurts@prodrive-technologies.com>
Cc: mgreer@animalcreek.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, conor+dt@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
martijn.de.gouw@prodrive-technologies.com
Subject: Re: [PATCH v3 2/2] NFC: trf7970a: Create device-tree parameter for RX gain reduction
Date: Fri, 27 Jun 2025 09:39:46 +0200 [thread overview]
Message-ID: <20250627-truthful-versed-civet-375ea4@krzk-bin> (raw)
In-Reply-To: <20250626141242.3749958-3-paul.geurts@prodrive-technologies.com>
On Thu, Jun 26, 2025 at 04:12:42PM +0200, Paul Geurts wrote:
> The TRF7970a device is sensitive to RF disturbances, which can make it
> hard to pass some EMC immunity tests. By reducing the RX antenna gain,
> the device becomes less sensitive to EMC disturbances, as a trade-off
> against antenna performance.
>
> Add a device tree option to select RX gain reduction to improve EMC
> performance.
>
> Selecting a communication standard in the ISO control register resets
> the RX antenna gain settings. Therefore set the RX gain reduction
> everytime the ISO control register changes, when the option is used.
>
> Signed-off-by: Paul Geurts <paul.geurts@prodrive-technologies.com>
> ---
> drivers/nfc/trf7970a.c | 91 +++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 80 insertions(+), 11 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-27 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 14:12 [PATCH v3 0/2] NFC: trf7970a: Add option to reduce antenna gain Paul Geurts
2025-06-26 14:12 ` [PATCH v3 1/2] dt-bindings: net/nfc: ti,trf7970a: Add ti,rx-gain-reduction-db option Paul Geurts
2025-06-27 7:10 ` Krzysztof Kozlowski
2025-06-30 8:14 ` Krzysztof Kozlowski
2025-06-30 8:54 ` Paul Geurts
2025-06-26 14:12 ` [PATCH v3 2/2] NFC: trf7970a: Create device-tree parameter for RX gain reduction Paul Geurts
2025-06-27 7:39 ` Krzysztof Kozlowski [this message]
2025-06-27 22:20 ` [PATCH v3 0/2] NFC: trf7970a: Add option to reduce antenna gain patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627-truthful-versed-civet-375ea4@krzk-bin \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martijn.de.gouw@prodrive-technologies.com \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.geurts@prodrive-technologies.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox