From: Jakub Kicinski <kuba@kernel.org>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com,
Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Subject: Re: [net-next, v2 10/10] bng_en: Add a network device
Date: Fri, 27 Jun 2025 17:24:11 -0700 [thread overview]
Message-ID: <20250627172411.12e36f84@kernel.org> (raw)
In-Reply-To: <20250626140844.266456-11-vikas.gupta@broadcom.com>
On Thu, 26 Jun 2025 14:08:19 +0000 Vikas Gupta wrote:
> +static netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struct net_device *dev)
> +{
you gotta free the packet here
> + return NETDEV_TX_OK;
> +}
> +
> +static int bnge_open(struct net_device *dev)
> +{
> + return 0;
> +}
> +
> +static int bnge_close(struct net_device *dev)
> +{
> + return 0;
> +}
prev parent reply other threads:[~2025-06-28 0:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 14:08 [net-next, v2 00/10] Introducing Broadcom BNGE Ethernet Driver Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 01/10] bng_en: Add PCI interface Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 02/10] bng_en: Add devlink interface Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 03/10] bng_en: Add firmware communication mechanism Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 04/10] bng_en: Add initial interaction with firmware Vikas Gupta
2025-06-28 0:22 ` Jakub Kicinski
2025-06-26 14:08 ` [net-next, v2 05/10] bng_en: Add ring memory allocation support Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 06/10] bng_en: Add backing store support Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 07/10] bng_en: Add resource management support Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 08/10] bng_en: Add irq allocation support Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 09/10] bng_en: Initialize default configuration Vikas Gupta
2025-06-26 14:08 ` [net-next, v2 10/10] bng_en: Add a network device Vikas Gupta
2025-06-28 0:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627172411.12e36f84@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).