netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	netdev@vger.kernel.org,  eric.dumazet@gmail.com,
	Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 1/4] net: add struct net_aligned_data
Date: Fri, 27 Jun 2025 20:05:48 +0000	[thread overview]
Message-ID: <20250627200551.348096-2-edumazet@google.com> (raw)
In-Reply-To: <20250627200551.348096-1-edumazet@google.com>

This structure will hold networking data that must
consume a full cache line to avoid accidental false sharing.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 include/net/aligned_data.h | 16 ++++++++++++++++
 net/core/hotdata.c         |  3 +++
 2 files changed, 19 insertions(+)
 create mode 100644 include/net/aligned_data.h

diff --git a/include/net/aligned_data.h b/include/net/aligned_data.h
new file mode 100644
index 0000000000000000000000000000000000000000..cf3329d7c2272ec4424e89352626800cbc282663
--- /dev/null
+++ b/include/net/aligned_data.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+#ifndef _NET_ALIGNED_DATA_H
+#define _NET_ALIGNED_DATA_H
+
+#include <linux/types.h>
+
+/* Structure holding cacheline aligned fields on SMP builds.
+ * Each field or group should have an ____cacheline_aligned_in_smp
+ * attribute to ensure no accidental false sharing can happen.
+ */
+struct net_aligned_data {
+};
+
+extern struct net_aligned_data net_aligned_data;
+
+#endif /* _NET_ALIGNED_DATA_H */
diff --git a/net/core/hotdata.c b/net/core/hotdata.c
index 0bc893d5f07b03b31e08967a2238f63d218020d7..e9c03491ab001cc85fd60ad28533649b32d8a003 100644
--- a/net/core/hotdata.c
+++ b/net/core/hotdata.c
@@ -2,6 +2,7 @@
 #include <linux/cache.h>
 #include <linux/jiffies.h>
 #include <linux/list.h>
+#include <net/aligned_data.h>
 #include <net/hotdata.h>
 #include <net/proto_memory.h>
 
@@ -22,3 +23,5 @@ struct net_hotdata net_hotdata __cacheline_aligned = {
 	.sysctl_mem_pcpu_rsv = SK_MEMORY_PCPU_RESERVE
 };
 EXPORT_SYMBOL(net_hotdata);
+
+struct net_aligned_data net_aligned_data;
-- 
2.50.0.727.gbf7dc18ff4-goog


  reply	other threads:[~2025-06-27 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 20:05 [PATCH net-next 0/4] net: introduce net_aligned_data Eric Dumazet
2025-06-27 20:05 ` Eric Dumazet [this message]
2025-06-28 14:48   ` [PATCH net-next 1/4] net: add struct net_aligned_data Willem de Bruijn
2025-06-27 20:05 ` [PATCH net-next 2/4] net: move net_cookie into net_aligned_data Eric Dumazet
2025-06-28 14:49   ` Willem de Bruijn
2025-06-28 20:19   ` kernel test robot
2025-06-27 20:05 ` [PATCH net-next 3/4] tcp: move tcp_memory_allocated " Eric Dumazet
2025-06-28 14:49   ` Willem de Bruijn
2025-06-28 22:14   ` kernel test robot
2025-06-27 20:05 ` [PATCH net-next 4/4] udp: move udp_memory_allocated " Eric Dumazet
2025-06-28 14:49   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627200551.348096-2-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).