netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET
@ 2025-06-30 15:33 Sebastian Andrzej Siewior
  2025-06-30 21:50 ` Cong Wang
  2025-07-02  0:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2025-06-30 15:33 UTC (permalink / raw)
  To: netdev, linux-kselftest
  Cc: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan

The config snippet specifies CONFIG_NET_EMATCH_IPSET. This option
depends on CONFIG_IP_SET.

Set CONFIG_IP_SET to be enabled at part for tc-testing.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 tools/testing/selftests/tc-testing/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
index db176fe7d0c3f..8e902f7f1a181 100644
--- a/tools/testing/selftests/tc-testing/config
+++ b/tools/testing/selftests/tc-testing/config
@@ -21,6 +21,7 @@ CONFIG_NF_NAT=m
 CONFIG_NETFILTER_XT_TARGET_LOG=m
 
 CONFIG_NET_SCHED=y
+CONFIG_IP_SET=m
 
 #
 # Queueing/Scheduling
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET
  2025-06-30 15:33 [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET Sebastian Andrzej Siewior
@ 2025-06-30 21:50 ` Cong Wang
  2025-07-01  0:22   ` Jakub Kicinski
  2025-07-02  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Cong Wang @ 2025-06-30 21:50 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: netdev, linux-kselftest, Jamal Hadi Salim, Jiri Pirko, Shuah Khan

On Mon, Jun 30, 2025 at 05:33:41PM +0200, Sebastian Andrzej Siewior wrote:
> The config snippet specifies CONFIG_NET_EMATCH_IPSET. This option
> depends on CONFIG_IP_SET.

So it should be set automatically when running `make` ? IOW, why do we
have to set it explicitly?

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET
  2025-06-30 21:50 ` Cong Wang
@ 2025-07-01  0:22   ` Jakub Kicinski
  0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2025-07-01  0:22 UTC (permalink / raw)
  To: Cong Wang
  Cc: Sebastian Andrzej Siewior, netdev, linux-kselftest,
	Jamal Hadi Salim, Jiri Pirko, Shuah Khan

On Mon, 30 Jun 2025 14:50:24 -0700 Cong Wang wrote:
> On Mon, Jun 30, 2025 at 05:33:41PM +0200, Sebastian Andrzej Siewior wrote:
> > The config snippet specifies CONFIG_NET_EMATCH_IPSET. This option
> > depends on CONFIG_IP_SET.  
> 
> So it should be set automatically when running `make` ? IOW, why do we
> have to set it explicitly?

EMATCH_IPSET `depend`s on IP_SET not `select`s ...
I think the patch makes sense. Or do you see another symbol which
should get us IP_SET in the resulting config?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET
  2025-06-30 15:33 [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET Sebastian Andrzej Siewior
  2025-06-30 21:50 ` Cong Wang
@ 2025-07-02  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-02  0:50 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: netdev, linux-kselftest, jhs, xiyou.wangcong, jiri, shuah

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 30 Jun 2025 17:33:41 +0200 you wrote:
> The config snippet specifies CONFIG_NET_EMATCH_IPSET. This option
> depends on CONFIG_IP_SET.
> 
> Set CONFIG_IP_SET to be enabled at part for tc-testing.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests/tc-testing: Enable CONFIG_IP_SET
    https://git.kernel.org/netdev/net-next/c/131e0a1123e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-02  0:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 15:33 [PATCH net-next] selftests/tc-testing: Enable CONFIG_IP_SET Sebastian Andrzej Siewior
2025-06-30 21:50 ` Cong Wang
2025-07-01  0:22   ` Jakub Kicinski
2025-07-02  0:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).