From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, mengyuanlou@net-swift.com,
duanqiangwen@net-swift.com, stable@vger.kernel.org
Subject: Re: [PATCH net] net: libwx: fix double put of page to page_pool
Date: Wed, 2 Jul 2025 14:31:52 -0700 [thread overview]
Message-ID: <20250702143152.6046ab7c@kernel.org> (raw)
In-Reply-To: <C8A23A11DB646E60+20250630094102.22265-1-jiawenwu@trustnetic.com>
On Mon, 30 Jun 2025 17:41:02 +0800 Jiawen Wu wrote:
> wx_dma_sync_frag() incorrectly attempted to return the page to
> page_pool, which is already handled via buffer reuse or wx_build_skb()
> paths.
The conditions is:
if (unlikely(WX_CB(skb)->page_released))
And only wx_put_rx_buffer() sets that to true. And it sets page to
NULL, so I don't understand how this is supposed to work.
Please improve the commit message, if not the code..
> Under high MTU and high throughput, this causes list corruption
> inside page_pool due to double free.
>
> [ 876.949950] Call Trace:
> [ 876.949951] <IRQ>
> [ 876.949952] __rmqueue_pcplist+0x53/0x2c0
> [ 876.949955] alloc_pages_bulk_noprof+0x2e0/0
This is just the stack trace you're missing the earlier lines which
tell us what problem happened and where.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-02 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 9:41 [PATCH net] net: libwx: fix double put of page to page_pool Jiawen Wu
2025-07-02 21:31 ` Jakub Kicinski [this message]
2025-07-03 2:00 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702143152.6046ab7c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).