From: Leon Romanovsky <leon@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Patrisious Haddad <phaddad@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH mlx5-next] net/mlx5: fs, fix RDMA TRANSPORT init cleanup flow
Date: Wed, 2 Jul 2025 21:02:43 +0300 [thread overview]
Message-ID: <20250702180243.GL6278@unreal> (raw)
In-Reply-To: <20250702144106.GF41770@horms.kernel.org>
On Wed, Jul 02, 2025 at 03:41:06PM +0100, Simon Horman wrote:
> On Wed, Jul 02, 2025 at 01:24:04PM +0300, Leon Romanovsky wrote:
> > From: Patrisious Haddad <phaddad@nvidia.com>
> >
> > Failing during the initialization of root_namespace didn't cleanup
> > the priorities of the namespace on which the failure occurred.
> >
> > Properly cleanup said priorities on failure.
> >
> > Fixes: e6746b0c7423 ("net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain")
>
> Hi Leon and Patrisious,
>
> Maybe there has been a rebase, there is something weird on my side, or for
> some reason it doesn't matter. But I see a different hash in mlx5-next [1].
>
> Fixes: 52931f55159e ("net/mlx5: fs, add multiple prios to RDMA TRANSPORT steering domain")
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
>
> > Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> Otherwise, LGTM.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Thanks a lot, you are right about Fixes lines, I fixed it locally when
applied the patch.
>
next prev parent reply other threads:[~2025-07-02 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 10:24 [PATCH mlx5-next] net/mlx5: fs, fix RDMA TRANSPORT init cleanup flow Leon Romanovsky
2025-07-02 14:41 ` Simon Horman
2025-07-02 18:02 ` Leon Romanovsky [this message]
2025-07-02 18:03 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702180243.GL6278@unreal \
--to=leon@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).