From: David Laight <david.laight.linux@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Feng Yang <yangfeng59949@163.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, willemb@google.com, almasrymina@google.com,
kerneljasonxing@gmail.com, ebiggers@google.com,
asml.silence@gmail.com, aleksander.lobakin@intel.com,
stfomichev@gmail.com, yangfeng@kylinos.cn,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] skbuff: Add MSG_MORE flag to optimize large packet transmission
Date: Thu, 3 Jul 2025 12:44:53 +0100 [thread overview]
Message-ID: <20250703124453.390f5908@pumpkin> (raw)
In-Reply-To: <e7275f92-5107-48d2-9a47-435b73c62ef4@redhat.com>
On Thu, 3 Jul 2025 10:48:40 +0200
Paolo Abeni <pabeni@redhat.com> wrote:
> On 6/30/25 9:10 AM, Feng Yang wrote:
> > From: Feng Yang <yangfeng@kylinos.cn>
> >
> > The "MSG_MORE" flag is added to improve the transmission performance of large packets.
> > The improvement is more significant for TCP, while there is a slight enhancement for UDP.
>
> I'm sorry for the conflicting input, but i fear we can't do this for
> UDP: unconditionally changing the wire packet layout may break the
> application, and or at very least incur in unexpected fragmentation issues.
Does the code currently work for UDP?
I'd have thought the skb being sent was an entire datagram.
But each semdmsg() is going to send a separate datagram.
IIRC for UDP MSG_MORE indicates that the next send() will be
part of the same datagram - so the actual send can't be done
until the final fragment (without MSG_MORE) is sent.
None of the versions is right for SCTP.
The skb being sent needs to be processed as a single entity.
Here MSG_MORE tells the stack that more messages follow and can be put
into a single ethernet frame - but they are separate protocol messages.
OTOH I've not looked at where this code is called from.
In particular, when it would be called with non-linear skb.
David
next prev parent reply other threads:[~2025-07-03 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 7:10 [PATCH v3] skbuff: Add MSG_MORE flag to optimize large packet transmission Feng Yang
2025-07-03 8:48 ` Paolo Abeni
2025-07-03 11:44 ` David Laight [this message]
2025-07-04 9:26 ` Feng Yang
2025-07-04 15:50 ` Paolo Abeni
2025-07-05 7:16 ` David Laight
2025-07-07 6:17 ` Feng Yang
2025-07-07 7:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703124453.390f5908@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
--cc=willemb@google.com \
--cc=yangfeng59949@163.com \
--cc=yangfeng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox