From: Gary Guo <gary@kernel.org>
To: gnault@redhat.com
Cc: davem@davemloft.net, idosch@idosch.org, kuba@kernel.org,
ling@moedove.com, netdev@vger.kernel.org, noc@moedove.com,
pabeni@redhat.com, Gary Guo <gary@garyguo.net>
Subject: Re: [BUG] net: gre: IPv6 link-local multicast is silently dropped (Regression)
Date: Sun, 6 Jul 2025 16:40:30 +0100 [thread overview]
Message-ID: <20250706154030.3010068-1-gary@kernel.org> (raw)
In-Reply-To: <aGUGBjVZZPBWcRlA@debian>
On Wed, 2 Jul 2025 12:12:22 +0200, Guillaume Nault wrote:
> Aiden, can you confirm that the following patch fixes the issue on your
> side?
Not Aiden, but I get hit with the same regression after updating kernel on my
router from v6.12.28 to v6.12.35 today. Symptom for me is bird complaining
about "Socket error: Network is unreachable", and strace shows that it's sending
packets to ff02::1:6 and get hit with ENETUNREACH.
I can confirm that applying this patch on top of v6.12.35 fixes the issue for me.
I also took a look of the code, not a net expert, but this approach does look
like a proper fix to me.
Reviewed-by: Gary Guo <gary@garyguo.net>
Tested-by: Gary Guo <gary@garyguo.net>
>
> ---- >8 ----
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index ba2ec7c870cc..870a0bd6c2ba 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3525,11 +3525,9 @@ static void addrconf_gre_config(struct net_device *dev)
>
> ASSERT_RTNL();
>
> - idev = ipv6_find_idev(dev);
> - if (IS_ERR(idev)) {
> - pr_debug("%s: add_dev failed\n", __func__);
> + idev = addrconf_add_dev(dev);
> + if (IS_ERR(idev))
> return;
> - }
>
> /* Generate the IPv6 link-local address using addrconf_addr_gen(),
> * unless we have an IPv4 GRE device not bound to an IP address and
> @@ -3543,9 +3541,6 @@ static void addrconf_gre_config(struct net_device *dev)
> }
>
> add_v4_addrs(idev);
> -
> - if (dev->flags & IFF_POINTOPOINT)
> - addrconf_add_mroute(dev);
> }
> #endif
next prev parent reply other threads:[~2025-07-06 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 6:40 [BUG] net: gre: IPv6 link-local multicast is silently dropped (Regression) Aiden Yang
2025-06-29 14:49 ` Ido Schimmel
2025-06-30 11:54 ` Guillaume Nault
2025-07-01 10:13 ` Ido Schimmel
2025-07-02 10:12 ` Guillaume Nault
2025-07-06 15:40 ` Gary Guo [this message]
2025-07-09 14:15 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250706154030.3010068-1-gary@kernel.org \
--to=gary@kernel.org \
--cc=davem@davemloft.net \
--cc=gary@garyguo.net \
--cc=gnault@redhat.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=ling@moedove.com \
--cc=netdev@vger.kernel.org \
--cc=noc@moedove.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).