From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: "MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Georgi Djakov" <djakov@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Johnson Wang" <johnson.wang@mediatek.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Felix Fietkau" <nbd@nbd.name>,
"Frank Wunderlich" <frank-w@public-files.de>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v8 02/16] dt-bindings: net: mediatek,net: allow up to 8 IRQs
Date: Mon, 7 Jul 2025 08:31:11 +0200 [thread overview]
Message-ID: <20250707-modest-awesome-baboon-aec601@krzk-bin> (raw)
In-Reply-To: <20250706132213.20412-3-linux@fw-web.de>
On Sun, Jul 06, 2025 at 03:21:57PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Increase the maximum IRQ count to 8 (4 FE + 4 RSS/LRO).
Because? Hardware was updated? It was missing before?
>
> Frame-engine-IRQs (max 4):
> MT7621, MT7628: 1 IRQ
> MT7622, MT7623: 3 IRQs (only two used by the driver for now)
> MT7981, MT7986, MT7988: 4 IRQs (only two used by the driver for now)
You updated commit msg - looks fine - but same problem as before in your
code. Now MT7981 has 4-8 interrupts, even though you say here it has only
4.
>
> Mediatek Filogic SoCs (mt798x) have 4 additional IRQs for RSS and/or
> LRO.
Although I don't know how to treat this. Just say how many interrupts
are there (MT7981, MT7986, MT7988: 4 FE and 4 RSS), not 4 but later
actually 4+4.
I also do not understand why 7 interrupts is now valid... Are these not
connected physically?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-07 6:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 13:21 [PATCH v8 00/16] further mt7988 devicetree work Frank Wunderlich
2025-07-06 13:21 ` [PATCH v8 01/16] dt-bindings: net: mediatek,net: update mac subnode pattern for mt7988 Frank Wunderlich
2025-07-07 6:27 ` Krzysztof Kozlowski
2025-07-06 13:21 ` [PATCH v8 02/16] dt-bindings: net: mediatek,net: allow up to 8 IRQs Frank Wunderlich
2025-07-07 6:31 ` Krzysztof Kozlowski [this message]
2025-07-07 7:30 ` Frank Wunderlich
2025-07-07 10:06 ` AngeloGioacchino Del Regno
2025-07-07 10:43 ` Frank Wunderlich
2025-07-14 7:41 ` Krzysztof Kozlowski
2025-07-06 13:21 ` [PATCH v8 03/16] dt-bindings: net: mediatek,net: allow irq names Frank Wunderlich
2025-07-07 10:12 ` AngeloGioacchino Del Regno
2025-07-06 13:21 ` [PATCH v8 04/16] dt-bindings: net: mediatek,net: add sram property Frank Wunderlich
2025-07-07 6:33 ` Krzysztof Kozlowski
2025-07-07 10:12 ` AngeloGioacchino Del Regno
2025-07-06 13:22 ` [PATCH v8 05/16] dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for mt7988 Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 06/16] dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 07/16] dt-bindings: interconnect: add mt7988-cci compatible Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 08/16] arm64: dts: mediatek: mt7988: add cci node Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 09/16] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 10/16] arm64: dts: mediatek: mt7988: add switch node Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 11/16] arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 12/16] arm64: dts: mediatek: mt7988a-bpi-r4: drop unused pins Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 13/16] arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 14/16] arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernet Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 15/16] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac Frank Wunderlich
2025-07-06 13:22 ` [PATCH v8 16/16] arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds Frank Wunderlich
2025-07-07 9:22 ` (subset) [PATCH v8 00/16] further mt7988 devicetree work AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707-modest-awesome-baboon-aec601@krzk-bin \
--to=krzk@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=johnson.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox