netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Lin Ma <linma@zju.edu.cn>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	stable@kernel.org
Subject: Re: [PATCH v1 2/2] appletalk: Fix type confusion in handle_ip_over_ddp
Date: Mon, 7 Jul 2025 09:52:10 +0100	[thread overview]
Message-ID: <20250707085210.GA89747@horms.kernel.org> (raw)
In-Reply-To: <20250703052837.15458-1-linma@zju.edu.cn>

On Thu, Jul 03, 2025 at 01:28:37PM +0800, Lin Ma wrote:
> This code uses "ipddp0" calling __dev_get_by_name(), believing it must
> return device created in ipddp_init() function, ignoring the fact that a
> malicious user could hijack the interface name.
> 
> Fortunately, the upstream kernel already removed the code via commit
> 85605fb694f0 ("appletalk: remove special handling code for ipddp"). This
> fix should be applied to other stable versions.
> 
> Cc: stable@kernel.org
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Thanks Lin Ma,

I agree that this code change looks good.
That the code in question has been present since git history started.
And was removed by the commit cited above, in v6.7-rc1.

Reviewed-by: Simon Horman <horms@kernel.org>


Greg,

I'm unsure how this case should be handled from a stable PoV.

...

  reply	other threads:[~2025-07-07  8:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  5:28 [PATCH v1 2/2] appletalk: Fix type confusion in handle_ip_over_ddp Lin Ma
2025-07-07  8:52 ` Simon Horman [this message]
2025-07-07 21:29 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707085210.GA89747@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linma@zju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).