From: Jakub Kicinski <kuba@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH net] net: phy: Don't register LEDs for genphy
Date: Mon, 7 Jul 2025 16:32:19 -0700 [thread overview]
Message-ID: <20250707163219.64c99f4d@kernel.org> (raw)
In-Reply-To: <20250707195803.666097-1-sean.anderson@linux.dev>
On Mon, 7 Jul 2025 15:58:03 -0400 Sean Anderson wrote:
> - if (IS_ENABLED(CONFIG_PHYLIB_LEDS))
> + if (IS_ENABLED(CONFIG_PHYLIB_LEDS) && !phy_driver_is_genphy(phydev) &&
> + !phy_driver_is_genphy_10g(phydev))
Breaks build for smaller configs:
drivers/net/phy/phy_device.c: In function ‘phy_probe’:
drivers/net/phy/phy_device.c:3506:14: error: implicit declaration of function ‘phy_driver_is_genphy_10g’; did you mean ‘phy_driver_is_genphy’? [-Werror=implicit-function-declaration]
3506 | !phy_driver_is_genphy_10g(phydev))
| ^~~~~~~~~~~~~~~~~~~~~~~~
| phy_driver_is_genphy
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-07 23:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 19:58 [PATCH net] net: phy: Don't register LEDs for genphy Sean Anderson
2025-07-07 23:32 ` Jakub Kicinski [this message]
2025-07-08 15:52 ` Sean Anderson
2025-07-10 17:40 ` Sean Anderson
2025-07-10 17:52 ` Jakub Kicinski
2025-07-10 18:17 ` Sean Anderson
2025-07-10 18:49 ` Jakub Kicinski
2025-07-10 18:57 ` Sean Anderson
2025-07-10 19:09 ` Jakub Kicinski
2025-07-08 8:58 ` Russell King (Oracle)
2025-07-08 15:33 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707163219.64c99f4d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox