From: Vladimir Oltean <olteanv@gmail.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: "kernel test robot" <lkp@intel.com>,
netdev@vger.kernel.org, "Paul Gazzillo" <paul@pgazz.com>,
"Necip Fazil Yildiran" <fazilyildiran@gmail.com>,
oe-kbuild-all@lists.linux.dev, "Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Clément Léger" <clement.leger@bootlin.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: dsa: rzn1_a5psw: add COMPILE_TEST
Date: Tue, 8 Jul 2025 00:33:25 +0300 [thread overview]
Message-ID: <20250707213325.b42szcgiuqurrx3h@skbuf> (raw)
In-Reply-To: <CAKxU2N83JjTG19_GD-9LPJfe=aY4tU+7dFjRhFqGeLDn6beGKQ@mail.gmail.com>
On Mon, Jul 07, 2025 at 01:47:49PM -0700, Rosen Penev wrote:
> so it's probably better to do
> depends on OF && (ARCH_RZN1 || COMPILE_TEST)
> to match the pcs driver.
>
> not sure it would fix this error though...
Yes, you can't select something which has "depends on", unless you
ensure that all its dependencies are satisfied.
If Kbuild has the same operator precedence as C, then "&&" has higher
precedence than "||", and "OF && ARCH_RZN1 || COMPILE_TEST" actually
evaluates to a different expression than "OF && (ARCH_RZN1 || COMPILE_TEST)".
The former can be true when OF=n, while the latter can't. Thus, OF=n is
an unsatisfied dependency for the PCS driver.
next prev parent reply other threads:[~2025-07-07 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 0:39 [PATCH 0/2] net: dsa: rzn1_a5psw: add COMPILE_TEST Rosen Penev
2025-07-07 0:39 ` [PATCH 1/2] " Rosen Penev
2025-07-07 5:55 ` Andrew Lunn
2025-07-07 6:01 ` Andrew Lunn
2025-07-07 20:25 ` kernel test robot
2025-07-07 20:47 ` Rosen Penev
2025-07-07 21:33 ` Vladimir Oltean [this message]
2025-07-07 0:39 ` [PATCH 2/2] net: dsa: rzn1_a5psw: use devm to enable clocks Rosen Penev
2025-07-07 5:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707213325.b42szcgiuqurrx3h@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=edumazet@google.com \
--cc=fazilyildiran@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=paul@pgazz.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox