From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 08/11] net_sched: act_nat: use RCU in tcf_nat_dump()
Date: Tue, 8 Jul 2025 13:59:58 +0100 [thread overview]
Message-ID: <20250708125958.GI452973@horms.kernel.org> (raw)
In-Reply-To: <20250708125411.GG452973@horms.kernel.org>
On Tue, Jul 08, 2025 at 01:54:11PM +0100, Simon Horman wrote:
> On Mon, Jul 07, 2025 at 01:01:07PM +0000, Eric Dumazet wrote:
...
> > @@ -294,12 +293,12 @@ static int tcf_nat_dump(struct sk_buff *skb, struct tc_action *a,
> > tcf_tm_dump(&t, &p->tcf_tm);
> > if (nla_put_64bit(skb, TCA_NAT_TM, sizeof(t), &t, TCA_NAT_PAD))
> > goto nla_put_failure;
> > - spin_unlock_bh(&p->tcf_lock);
> > + rcu_read_lock();
>
> Hi Eric,
>
> Should this be rcu_read_unlock()?
> ^^
>
> Flagged by Smatch.
s/Smatch/Sparse/
...
next prev parent reply other threads:[~2025-07-08 13:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 13:00 [PATCH net-next 00/11] net_sched: act: extend RCU use in dump() methods Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 01/11] net_sched: act: annotate data-races in tcf_lastuse_update() and tcf_tm_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 02/11] net_sched: act_connmark: use RCU in tcf_connmark_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 03/11] net_sched: act_csum: use RCU in tcf_csum_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 04/11] net_sched: act_ct: use RCU in tcf_ct_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 05/11] net_sched: act_ctinfo: use atomic64_t for three counters Eric Dumazet
2025-07-07 15:53 ` Pedro Tammela
2025-07-07 13:01 ` [PATCH net-next 06/11] net_sched: act_ctinfo: use RCU in tcf_ctinfo_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 07/11] net_sched: act_mpls: use RCU in tcf_mpls_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 08/11] net_sched: act_nat: use RCU in tcf_nat_dump() Eric Dumazet
2025-07-08 12:54 ` Simon Horman
2025-07-08 12:59 ` Simon Horman [this message]
2025-07-08 13:20 ` Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 09/11] net_sched: act_pedit: use RCU in tcf_pedit_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 10/11] net_sched: act_police: use RCU in tcf_police_dump() Eric Dumazet
2025-07-07 13:01 ` [PATCH net-next 11/11] net_sched: act_skbedit: use RCU in tcf_skbedit_dump() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708125958.GI452973@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox