From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, andrew@lunn.ch,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
bbhushan2@marvell.com, tariqt@nvidia.com, mbloch@nvidia.com,
leon@kernel.org, gal@nvidia.com, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next v3 2/5] eth: ice: drop the dead code related to rss_contexts
Date: Tue, 8 Jul 2025 16:56:10 +0100 [thread overview]
Message-ID: <20250708155610.GO452973@horms.kernel.org> (raw)
In-Reply-To: <20250707184115.2285277-3-kuba@kernel.org>
On Mon, Jul 07, 2025 at 11:41:12AM -0700, Jakub Kicinski wrote:
> ICE appears to have some odd form of rss_context use plumbed
> in for .get_rxfh. The .set_rxfh side does not support creating
> contexts, however, so this must be dead code. For at least a year
> now (since commit 7964e7884643 ("net: ethtool: use the tracking
> array for get_rxfh on custom RSS contexts")) we have not been
> calling .get_rxfh with a non-zero rss_context. We just get
> the info from the RSS XArray under dev->ethtool.
>
> Remove what must be dead code in the driver, clear the support flags.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-08 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 18:41 [PATCH net-next v3 0/5] net: migrate remaining drivers to dedicated _rxfh_context ops Jakub Kicinski
2025-07-07 18:41 ` [PATCH net-next v3 1/5] eth: otx2: migrate to the *_rxfh_context ops Jakub Kicinski
2025-07-08 15:55 ` Simon Horman
2025-07-07 18:41 ` [PATCH net-next v3 2/5] eth: ice: drop the dead code related to rss_contexts Jakub Kicinski
2025-07-08 15:56 ` Simon Horman [this message]
2025-07-07 18:41 ` [PATCH net-next v3 3/5] eth: mlx5: migrate to the *_rxfh_context ops Jakub Kicinski
2025-07-08 16:03 ` Gal Pressman
2025-07-07 18:41 ` [PATCH net-next v3 4/5] net: ethtool: remove the compat code for _rxfh_context ops Jakub Kicinski
2025-07-07 22:13 ` Edward Cree
2025-07-07 18:41 ` [PATCH net-next v3 5/5] net: ethtool: reduce indent " Jakub Kicinski
2025-07-07 22:13 ` Edward Cree
2025-07-08 19:10 ` [PATCH net-next v3 0/5] net: migrate remaining drivers to dedicated " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708155610.GO452973@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).