netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next V6 12/13] devlink: Implement devlink param multi attribute nested data values
Date: Wed, 9 Jul 2025 09:41:03 +0100	[thread overview]
Message-ID: <20250709084103.GN452973@horms.kernel.org> (raw)
In-Reply-To: <20250709030456.1290841-13-saeed@kernel.org>

On Tue, Jul 08, 2025 at 08:04:54PM -0700, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> Devlink param value attribute is not defined since devlink is handling
> the value validating and parsing internally, this allows us to implement
> multi attribute values without breaking any policies.
> 
> Devlink param multi-attribute values are considered to be dynamically
> sized arrays of u32 values, by introducing a new devlink param type
> DEVLINK_PARAM_TYPE_ARR_U32, driver and user space can set a variable
> count of u32 values into the DEVLINK_ATTR_PARAM_VALUE_DATA attribute.
> 
> Implement get/set parsing and add to the internal value structure passed
> to drivers.
> 
> This is useful for devices that need to configure a list of values for
> a specific configuration.
> 
> example:
>  $ devlink dev param show pci/... name multi-value-param
>     name multi-value-param type driver-specific
>     values:
>       cmode permanent value: 0,1,2,3,4,5,6,7
> 
>  $ devlink dev param set pci/... name multi-value-param \
> 	value 4,5,6,7,0,1,2,3 cmode permanent
> 
> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2025-07-09  8:41 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  3:04 [PATCH net-next V6 00/13] devlink, mlx5: Add new parameters for link management and SRIOV/eSwitch configurations Saeed Mahameed
2025-07-09  3:04 ` [PATCH net-next V6 01/13] devlink: Add 'total_vfs' generic device param Saeed Mahameed
2025-07-09  8:36   ` Simon Horman
2025-07-10  2:53   ` Jakub Kicinski
2025-07-10  5:38     ` Saeed Mahameed
2025-09-02 21:24       ` Jacob Keller
2025-09-03 21:32         ` Saeed Mahameed
2025-07-09  3:04 ` [PATCH net-next V6 02/13] net/mlx5: Implement cqe_compress_type via devlink params Saeed Mahameed
2025-07-09  8:37   ` Simon Horman
2025-07-09  9:06   ` Subbaraya Sundeep
2025-07-10  5:51     ` Saeed Mahameed
2025-07-11 16:19       ` Subbaraya Sundeep
2025-07-10  2:53   ` Jakub Kicinski
2025-07-10  5:44     ` Saeed Mahameed
2025-07-10 22:16       ` Jakub Kicinski
2025-07-09  3:04 ` [PATCH net-next V6 03/13] net/mlx5: Implement devlink enable_sriov parameter Saeed Mahameed
2025-07-09  8:37   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 04/13] net/mlx5: Implement devlink total_vfs parameter Saeed Mahameed
2025-07-09  8:37   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 05/13] devlink: pass struct devlink_port * as arg to devlink_nl_param_fill() Saeed Mahameed
2025-07-09  8:38   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 06/13] devlink: Implement port params registration Saeed Mahameed
2025-07-09  8:38   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 07/13] devlink: Implement get/dump netlink commands for port params Saeed Mahameed
2025-07-09  8:38   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 08/13] devlink: Implement set netlink command " Saeed Mahameed
2025-07-09  8:40   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 09/13] devlink: Add 'keep_link_up' generic devlink device param Saeed Mahameed
2025-07-09  8:40   ` Simon Horman
2025-07-10  2:58   ` Jakub Kicinski
2025-07-10  6:04     ` Saeed Mahameed
2025-07-10 12:45       ` Jiri Pirko
2025-07-10 22:24       ` Jakub Kicinski
2025-08-28 20:09         ` Saeed Mahameed
2025-08-28 22:38           ` Jakub Kicinski
2025-09-02 19:02             ` Saeed Mahameed
2025-09-02 21:57           ` Jacob Keller
2025-09-03  6:45             ` Saeed Mahameed
2025-09-03 19:59               ` Jacob Keller
2025-09-03 21:30                 ` Saeed Mahameed
2025-07-09  3:04 ` [PATCH net-next V6 10/13] net/mlx5: Implement devlink keep_link_up port parameter Saeed Mahameed
2025-07-09  8:40   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 11/13] devlink: Throw extack messages on param value validation error Saeed Mahameed
2025-07-09  8:40   ` Simon Horman
2025-07-09  3:04 ` [PATCH net-next V6 12/13] devlink: Implement devlink param multi attribute nested data values Saeed Mahameed
2025-07-09  8:41   ` Simon Horman [this message]
2025-07-09  3:04 ` [PATCH net-next V6 13/13] net/mlx5: Implement eSwitch hairpin per prio buffers devlink params Saeed Mahameed
2025-07-09  8:41   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709084103.GN452973@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeed@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).