From: Jakub Kicinski <kuba@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, horms@kernel.org, cratiu@nvidia.com,
noren@nvidia.com, cjubran@nvidia.com, mbloch@nvidia.com,
jdamato@fastly.com, gal@nvidia.com, sdf@fomichev.me,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP support
Date: Wed, 9 Jul 2025 13:37:45 -0700 [thread overview]
Message-ID: <20250709133745.2a8ddfb8@kernel.org> (raw)
In-Reply-To: <20250709173707.3177206-3-mohsin.bashr@gmail.com>
On Wed, 9 Jul 2025 10:37:04 -0700 Mohsin Bashir wrote:
> +#include <xdp/xdp_helpers.h>
> +#include <xdp/prog_dispatcher.h>
Hm, you don't appear to use these headers and they require installing
libxdp-devel (which is not universally packaged, sadly). Could you
remove? Also these headers are reportedly unused:
#include <linux/tcp.h>
#include <linux/bpf_common.h>
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-09 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 17:37 [PATCH net-next 0/5] selftests: drv-net: Test XDP native support Mohsin Bashir
2025-07-09 17:37 ` [PATCH net-next 1/5] selftests: drv-net: Add bpftool util Mohsin Bashir
2025-07-09 17:37 ` [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP support Mohsin Bashir
2025-07-09 20:37 ` Jakub Kicinski [this message]
2025-07-09 17:37 ` [PATCH net-next 3/5] selftests: drv-net: Test XDP_TX support Mohsin Bashir
2025-07-09 17:37 ` [PATCH net-next 4/5] selftests: drv-net: Test tail-adjustment support Mohsin Bashir
2025-07-09 17:37 ` [PATCH net-next 5/5] selftests: drv-net: Test head-adjustment support Mohsin Bashir
-- strict thread matches above, loose matches on Subject: below --
2025-07-10 18:43 [PATCH net-next V2 0/5] selftests: drv-net: Test XDP native support Mohsin Bashir
2025-07-10 18:43 ` [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP support Mohsin Bashir
2025-07-11 13:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709133745.2a8ddfb8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=mbloch@nvidia.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).