From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B7B27FD70 for ; Thu, 10 Jul 2025 02:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752115983; cv=none; b=DCsEq6gn3nITMTeRso3om0Qnk/UIwUt9HkuZBzjdumhCyEi2HXJ/vFwjsCz5yg7RFDclKtMpx5Dyuqn5JwZ2mFNdGl/VSEMlCztuFLBR4lAF63LedtwBGZswczvARyYvuoaXpYe2J367ac/T79LMH91s75w+UcRpdfLcqgoYho0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752115983; c=relaxed/simple; bh=NMRmAK2KYP4WZcdZi+oNd7+9RY6uNkf4cScTHVvvcuQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QaMjpURXZpSwdgKac8oMYBTvKB3rJBbg40zkXlciTwar7hDy/fcyD+BDAC9T80vY4bk8iWrtG86SJKdpYXlthaLtYDenp2elsicHCckcZHqpcX32uBbAukc2MQEZksN2hxeE97bKuQBcZ5cytuvi2954D3XvVrr5qEB3B+eoiWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iMCW4uqw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iMCW4uqw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD09C4CEF0; Thu, 10 Jul 2025 02:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752115982; bh=NMRmAK2KYP4WZcdZi+oNd7+9RY6uNkf4cScTHVvvcuQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iMCW4uqw2AcntkLRaXGdOiVkb6mMcYOyiYBsj0bOnUNMV5245vDX4XHSi0JbRtd++ MTEzwEFHSR/jlGxuyGoobop5TYC+WdaWS2V+u8VXy7u1n7yAhYdf9CIFP7/xWikpyM yl3sNaRCqyB2Y4QW1gUHFtNTrQHKf1rjLYzdDz1vU8qL3NGWIuZwyjyAaw66yPA60a m5TE67BNcC88SaRvu2/5bONTwqfCE+6+aScdn9p5CL1yrVZVzF/JH3yXP1O12gc16Z GV8OETGH1Dqc+Qa92jVgLhTCbJ3rlvFONJJkeXeWWSy/q//NvHLydnNajKexfTSaRh Wup4Y0XD/i9gw== Date: Wed, 9 Jul 2025 19:53:00 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , Jiri Pirko , Simon Horman Subject: Re: [PATCH net-next V6 02/13] net/mlx5: Implement cqe_compress_type via devlink params Message-ID: <20250709195300.6d393e90@kernel.org> In-Reply-To: <20250709030456.1290841-3-saeed@kernel.org> References: <20250709030456.1290841-1-saeed@kernel.org> <20250709030456.1290841-3-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 8 Jul 2025 20:04:44 -0700 Saeed Mahameed wrote: > Selects which algorithm should be used by the NIC in order to decide rate of > CQE compression dependeng on PCIe bus conditions. > > Supported values: > > 1) balanced, merges fewer CQEs, resulting in a moderate compression ratio > but maintaining a balance between bandwidth savings and performance > 2) aggressive, merges more CQEs into a single entry, achieving a higher > compression rate and maximizing performance, particularly under high > traffic loads. This description sounds like 'aggressive' always wins. Higher compression rate and higher performance. You gotta describe the trade offs for the knobs. > diff --git a/Documentation/networking/devlink/mlx5.rst b/Documentation/networking/devlink/mlx5.rst > index 7febe0aecd53..417e5cdcd35d 100644 > --- a/Documentation/networking/devlink/mlx5.rst > +++ b/Documentation/networking/devlink/mlx5.rst > @@ -117,6 +117,15 @@ parameters. > - driverinit > - Control the size (in packets) of the hairpin queues. > > + * - ``cqe_compress_type`` > + - string > + - permanent > + - Configure which algorithm should be used by the NIC in order to decide > + rate of CQE compression dependeng on PCIe bus conditions. > + > + * ``balanced`` : Merges fewer CQEs, resulting in a moderate compression ratio but maintaining a balance between bandwidth savings and performance > + * ``aggressive`` : Merges more CQEs into a single entry, achieving a higher compression rate and maximizing performance, particularly under high traffic loads Line wrap please. You already have a rx_cqe_compress ethtool priv flag. Why is this needed and how it differs. Is it just the default value for the ethtool setting? -- pw-bot: cr