From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Simon Horman" <horms@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: [PATCH net-next v3 2/3] selftests: ethtool: Drop the unused old_netdevs variable
Date: Thu, 10 Jul 2025 08:22:46 +0200 [thread overview]
Message-ID: <20250710062248.378459-3-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20250710062248.378459-1-maxime.chevallier@bootlin.com>
old_netdevs is unused in ethtool-common.sh. Only the UDP tunnels test
uses that variable, but it maintains it locally.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
.../testing/selftests/drivers/net/netdevsim/ethtool-common.sh | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
index 80160579e0cc..d9c7a3d397a9 100644
--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
@@ -43,13 +43,11 @@ function check {
}
function make_netdev {
- # Make a netdevsim
- old_netdevs=$(ls /sys/class/net)
-
if ! $(lsmod | grep -q netdevsim); then
modprobe netdevsim
fi
+ # Make a netdevsim
echo $NSIM_ID $@ > /sys/bus/netdevsim/new_device
udevadm settle
# get new device name
--
2.49.0
next prev parent reply other threads:[~2025-07-10 6:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 6:22 [PATCH net-next v3 0/3] netdevsim: add support for PHY devices Maxime Chevallier
2025-07-10 6:22 ` [PATCH net-next v3 1/3] net: netdevsim: Add PHY support in netdevsim Maxime Chevallier
2025-07-11 23:55 ` Jakub Kicinski
2025-07-15 6:08 ` Maxime Chevallier
2025-07-12 16:54 ` Andrew Lunn
2025-07-15 6:05 ` Maxime Chevallier
2025-07-15 13:23 ` Andrew Lunn
2025-07-15 13:56 ` Maxime Chevallier
2025-07-15 15:16 ` Andrew Lunn
2025-07-10 6:22 ` Maxime Chevallier [this message]
2025-07-10 6:22 ` [PATCH net-next v3 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim Maxime Chevallier
2025-07-11 23:58 ` Jakub Kicinski
2025-07-15 5:45 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710062248.378459-3-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).