* [TEST] net/udpgro.sh is flaky on debug
@ 2025-07-10 14:09 Jakub Kicinski
2025-07-10 14:20 ` Paolo Abeni
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-07-10 14:09 UTC (permalink / raw)
To: Paolo Abeni, Hangbin Liu; +Cc: netdev
Hi!
net/udpgro.sh has around 6% false positive rate on the debug kernels :(
Please see:
https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=udpgro-sh&ld_cnt=200&pass=0
for recent failures.
Is there anything we can do to make it more resilient ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [TEST] net/udpgro.sh is flaky on debug
2025-07-10 14:09 [TEST] net/udpgro.sh is flaky on debug Jakub Kicinski
@ 2025-07-10 14:20 ` Paolo Abeni
2025-07-10 17:23 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Abeni @ 2025-07-10 14:20 UTC (permalink / raw)
To: Jakub Kicinski, Hangbin Liu; +Cc: netdev
On 7/10/25 4:09 PM, Jakub Kicinski wrote:
> net/udpgro.sh has around 6% false positive rate on the debug kernels :(
>
> Please see:
> https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=udpgro-sh&ld_cnt=200&pass=0
> for recent failures.
>
> Is there anything we can do to make it more resilient ?
As most failures happen while waiting for the 'following' packets in non
GRO scenarios, a trivial attempt could increasing the inter-packet
timeout (currently 10ms).
Something alike the following. I can send a formal patch, and we can let
it stage in PW for a bit to observe if it actually helps.
/P
---
diff --git a/tools/testing/selftests/net/udpgro.sh
b/tools/testing/selftests/net/udpgro.sh
index 1dc337c709f8..43fcd4b0f6a2 100755
--- a/tools/testing/selftests/net/udpgro.sh
+++ b/tools/testing/selftests/net/udpgro.sh
@@ -48,7 +48,7 @@ run_one() {
cfg_veth
- ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10
${rx_args} &
+ ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 100
${rx_args} &
local PID1=$!
wait_local_port_listen ${PEER_NS} 8000 udp
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-10 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-10 14:09 [TEST] net/udpgro.sh is flaky on debug Jakub Kicinski
2025-07-10 14:20 ` Paolo Abeni
2025-07-10 17:23 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).