From: Oscar Maes <oscmaes92@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: ipv4: fix incorrect MTU in broadcast routes
Date: Thu, 10 Jul 2025 16:16:48 +0200 [thread overview]
Message-ID: <20250710141648-oscmaes92@gmail.com> (raw)
In-Reply-To: <20250708185430.68f143a2@kernel.org>
On Tue, Jul 08, 2025 at 06:54:30PM -0700, Jakub Kicinski wrote:
> On Thu, 3 Jul 2025 17:28:37 +0200 Oscar Maes wrote:
> > if (type == RTN_BROADCAST) {
> > flags |= RTCF_BROADCAST | RTCF_LOCAL;
> > - fi = NULL;
> > } else if (type == RTN_MULTICAST) {
> > flags |= RTCF_MULTICAST | RTCF_LOCAL;
> > if (!ip_check_mc_rcu(in_dev, fl4->daddr, fl4->saddr,
>
> Not super familiar with this code, but do we not need to set
> do_cache = false; ? I'm guessing cache interactions may have
> been the reason fib_info was originally cleared, not sure if
> that's still relevant..
>
> I'd also target this at net-next, unless you can pinpoint
> some kernel version where MTU on bcast routes worked..
> --
> pw-bot: cr
The caching mechanism was introduced after this line, back when nhc was embedded in fib_info.
(see https://lore.kernel.org/netdev/20120720.142612.691540831359186107.davem@davemloft.net/)
I'll resend to net-next.
prev parent reply other threads:[~2025-07-10 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 15:28 [PATCH net v2 1/2] net: ipv4: fix incorrect MTU in broadcast routes Oscar Maes
2025-07-03 15:28 ` [PATCH net v2 2/2] selftests: net: add test for variable PMTU " Oscar Maes
2025-07-09 1:54 ` [PATCH net v2 1/2] net: ipv4: fix incorrect MTU " Jakub Kicinski
2025-07-10 14:16 ` Oscar Maes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710141648-oscmaes92@gmail.com \
--to=oscmaes92@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).