From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next v3 1/8] net: s/dev_get_stats/netif_get_stats/
Date: Thu, 10 Jul 2025 17:46:04 -0700 [thread overview]
Message-ID: <20250710174604.5745276d@kernel.org> (raw)
In-Reply-To: <20250708213829.875226-2-sdf@fomichev.me>
On Tue, 8 Jul 2025 14:38:22 -0700 Stanislav Fomichev wrote:
> Commit cc34acd577f1 ("docs: net: document new locking reality")
> introduced netif_ vs dev_ function semantics: the former expects locked
> netdev, the latter takes care of the locking. We don't strictly
> follow this semantics on either side, but there are more dev_xxx handlers
> now that don't fit. Rename them to netif_xxx where appropriate.
TBH dev_get_stats() is neither locked or unlocked.
Procfs calls it with just rcu lock. I'd skip this patch.
next prev parent reply other threads:[~2025-07-11 0:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 21:38 [PATCH net-next v3 0/8] net: maintain netif vs dev prefix semantics Stanislav Fomichev
2025-07-08 21:38 ` [PATCH net-next v3 1/8] net: s/dev_get_stats/netif_get_stats/ Stanislav Fomichev
2025-07-11 0:46 ` Jakub Kicinski [this message]
2025-07-08 21:38 ` [PATCH net-next v3 2/8] net: s/dev_get_port_parent_id/netif_get_port_parent_id/ Stanislav Fomichev
2025-07-11 0:52 ` Jakub Kicinski
2025-07-08 21:38 ` [PATCH net-next v3 3/8] net: s/dev_get_mac_address/netif_get_mac_address/ Stanislav Fomichev
2025-07-08 21:38 ` [PATCH net-next v3 4/8] net: s/dev_pre_changeaddr_notify/netif_pre_changeaddr_notify/ Stanislav Fomichev
2025-07-08 21:38 ` [PATCH net-next v3 5/8] net: s/__dev_set_mtu/__netif_set_mtu/ Stanislav Fomichev
2025-07-09 13:35 ` Jakub Kicinski
2025-07-08 21:38 ` [PATCH net-next v3 6/8] net: s/dev_get_flags/netif_get_flags/ Stanislav Fomichev
2025-07-08 21:38 ` [PATCH net-next v3 7/8] net: s/dev_set_threaded/netif_set_threaded/ Stanislav Fomichev
2025-07-08 21:38 ` [PATCH net-next v3 8/8] net: s/dev_close_many/netif_close_many/ Stanislav Fomichev
2025-07-11 0:57 ` [PATCH net-next v3 0/8] net: maintain netif vs dev prefix semantics Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710174604.5745276d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).