From: Stephen Hemminger <stephen@networkplumber.org>
To: Li Tian <litian@redhat.com>
Cc: netdev@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH v2] hv_netvsc: Add IFF_NO_ADDRCONF to VF priv_flags before
Date: Thu, 10 Jul 2025 21:07:29 -0700 [thread overview]
Message-ID: <20250710210729.36231c98@hermes.local> (raw)
In-Reply-To: <20250711034021.11668-1-litian@redhat.com>
On Fri, 11 Jul 2025 11:39:58 +0800
Li Tian <litian@redhat.com> wrote:
> Add an additional flag IFF_NO_ADDRCONF to prevent ipv6 addrconf.
>
> Commit 8a321cf7becc6c065ae595b837b826a2a81036b9
> ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")
>
> This new flag change was not made to hv_netvsc resulting in the VF being
> assinged an IPv6.
>
> Suggested-by: Cathy Avery <cavery@redhat.com>
>
> Signed-off-by: Li Tian <litian@redhat.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index c41a025c66f0..8be9bce66a4e 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2317,8 +2317,11 @@ static int netvsc_prepare_bonding(struct net_device *vf_netdev)
> if (!ndev)
> return NOTIFY_DONE;
>
> - /* set slave flag before open to prevent IPv6 addrconf */
> + /* Set slave flag and no addrconf flag before open
> + * to prevent IPv6 addrconf.
> + */
> vf_netdev->flags |= IFF_SLAVE;
> + vf_netdev->priv_flags |= IFF_NO_ADDRCONF;
> return NOTIFY_DONE;
> }
>
Thanks this worked originally but got broken, please add:
Fixes: 8a321cf7becc ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")
Cc: lucien.xin@gmail.com
Looks like team and failover have the same problem.
next prev parent reply other threads:[~2025-07-11 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 2:46 [PATCH] hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf Li Tian
2025-07-10 20:24 ` [EXTERNAL] " Haiyang Zhang
2025-07-10 20:28 ` Haiyang Zhang
2025-07-11 3:39 ` [PATCH v2] hv_netvsc: Add IFF_NO_ADDRCONF to VF priv_flags before Li Tian
2025-07-11 4:07 ` Stephen Hemminger [this message]
2025-07-11 4:06 ` [PATCH v2] hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf Li Tian
2025-07-11 14:58 ` Stephen Hemminger
2025-07-11 4:17 ` Li Tian
2025-07-11 23:12 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710210729.36231c98@hermes.local \
--to=stephen@networkplumber.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=litian@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).