From: Jakub Kicinski <kuba@kernel.org>
To: Vincent Whitchurch via B4 Relay
<devnull+vincent.whitchurch.datadoghq.com@kernel.org>
Cc: vincent.whitchurch@datadoghq.com,
John Fastabend <john.fastabend@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 0/5] sockmap: Fix reading with splice(2)
Date: Fri, 11 Jul 2025 16:09:31 -0700 [thread overview]
Message-ID: <20250711160931.12ec952a@kernel.org> (raw)
In-Reply-To: <20250709-sockmap-splice-v3-0-b23f345a67fc@datadoghq.com>
On Wed, 09 Jul 2025 14:47:56 +0200 Vincent Whitchurch via B4 Relay
wrote:
> I noticed that if the verdict callback returns SK_PASS, using splice(2)
> to read from a socket in a sockmap does not work since it never sees the
> data queued on to it. As far as I can see, this is not a regression but
> just something that has never worked, but it does make sockmap unusable
> if you can't guarantee that the programs using the socket will not use
> splice(2).
On v2 you should you can't replace ops for passively opened
connections. Can that not be addressed instead of adding
an indirect call on the data path?
next prev parent reply other threads:[~2025-07-11 23:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 12:47 [PATCH bpf-next v3 0/5] sockmap: Fix reading with splice(2) Vincent Whitchurch via B4 Relay
2025-07-09 12:47 ` [PATCH bpf-next v3 1/5] net: Add splice_read to prot Vincent Whitchurch via B4 Relay
2025-07-11 17:27 ` John Fastabend
2025-07-11 18:48 ` Kuniyuki Iwashima
2025-07-11 18:52 ` Kuniyuki Iwashima
2025-07-09 12:47 ` [PATCH bpf-next v3 2/5] tcp_bpf: Fix reading with splice(2) Vincent Whitchurch via B4 Relay
2025-07-09 12:47 ` [PATCH bpf-next v3 3/5] selftests/bpf: sockmap: Exit with error on failure Vincent Whitchurch via B4 Relay
2025-07-09 12:48 ` [PATCH bpf-next v3 4/5] selftests/bpf: sockmap: Allow SK_PASS in verdict Vincent Whitchurch via B4 Relay
2025-07-09 12:48 ` [PATCH bpf-next v3 5/5] selftests/bpf: sockmap: Add splice + SK_PASS regression test Vincent Whitchurch via B4 Relay
2025-07-11 15:57 ` [PATCH bpf-next v3 0/5] sockmap: Fix reading with splice(2) John Fastabend
2025-07-11 23:09 ` Jakub Kicinski [this message]
2025-07-22 3:33 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711160931.12ec952a@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=devnull+vincent.whitchurch.datadoghq.com@kernel.org \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=vincent.whitchurch@datadoghq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).