From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE46288D2; Sat, 12 Jul 2025 00:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281005; cv=none; b=KY4DoNsbvnSvSww5R0ydoD611+uWAktbKcgovH87nCKgKJi7z34CzOShdbIcHJcNoQwfRyEoS3XunyGs7QO5ASQ3oEfIptRVppYUfErP+N+vL8P5bY/LuIOErqa3wiDyZW0OxiU89H9smkmOVbXgRihOS7Thp9wtidKlwF+qDjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281005; c=relaxed/simple; bh=N7T8fp/TykjVgARHYgLV5Gqff32nPYS+SnujgOw7C0g=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SFFCSr63rVEkx3Z6IEs0n17HT+pwRczYVa5d9Sv/tf8wfOHuqFkZTmx+Ym6up4EfX2Opqk9xGjbjFXtmmGdaL7MqVolmGOLbc4Ipv/eRztIxcVkU/xvyTxPUZpjprf9qtYSxd5YIBcYbvDigBVDW+3+tRj0ScOBAS4pLVUvY8ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kXpvlekc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kXpvlekc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8379AC4CEED; Sat, 12 Jul 2025 00:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752281005; bh=N7T8fp/TykjVgARHYgLV5Gqff32nPYS+SnujgOw7C0g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kXpvlekcgihMfw6+PyVzMNUN0mhwQ9D7FVUKXsYES/ecjJC97MrQKqwW8Lymh+qO2 EIo6HFNCwYmeGl1TfZaX7mzj4EroatpFZlIbhVSD25KF7Lc3hf6vbpHOr9YlxIp95o VEjUtwdtK1sMkxpDAMPaYEM8lx0KNaWNlS1qUr5zEww9e+pKbNyTwPA6Vb5iy1RjbD ZsZMuldvMj5QnBxPiJnpkM6otkWVi7rjVySwCX/z7nqudOuun7BUKj7QVOvL30cwYj YjJtNxOlektTT9DJdwUIOxbhoveFMSRk9AAZcOcb3mhtCXTIoJJ9O/fkL3x7hYAxth Pdz6mclN2fb9A== Date: Fri, 11 Jul 2025 17:43:23 -0700 From: Jakub Kicinski To: Fan Gong Cc: Zhu Yikai , , , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , , Jonathan Corbet , Bjorn Helgaas , luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Fu Guiming , Meny Yossefi , Gur Stavi , Lee Trager , Michael Ellerman , Vadim Fedorenko , Suman Ghosh , Przemek Kitszel , Joe Damato , Christophe JAILLET Subject: Re: [PATCH net-next v08 1/8] hinic3: Async Event Queue interfaces Message-ID: <20250711174323.5f756f47@kernel.org> In-Reply-To: <4b002d861f1f58ff4b970ef5fecf9d18338fde1c.1752126177.git.zhuyikai1@h-partners.com> References: <4b002d861f1f58ff4b970ef5fecf9d18338fde1c.1752126177.git.zhuyikai1@h-partners.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 10 Jul 2025 14:08:17 +0800 Fan Gong wrote: > +u32 hinic3_hwif_read_reg(struct hinic3_hwif *hwif, u32 reg) > +{ > + void __iomem *addr = hinic3_reg_addr(hwif, reg); > + __be32 raw_val; > + > + raw_val = (__force __be32)readl(addr); > + > + return be32_to_cpu(raw_val); > +} > + > +void hinic3_hwif_write_reg(struct hinic3_hwif *hwif, u32 reg, u32 val) > +{ > + void __iomem *addr = hinic3_reg_addr(hwif, reg); > + __be32 raw_val = cpu_to_be32(val); > + > + writel((__force u32)raw_val, addr); You should probably use iowrite32be and ioread32be here > + queue_work_on(WORK_CPU_UNBOUND, aeqs->workq, &eq->aeq_work); What's the point of calling queue_work_on() if you're passing UNBOUND > + wmb(); /* Write the init values */ barriers are not a flush, you need to say what writes this is _separating_ > + err = request_irq(eq->irq_id, aeq_interrupt, 0, > + eq->irq_name, eq); > + > + return err; you can return request_irq()s retval directly > + synchronize_irq(eq->irq_id); > + free_irq(eq->irq_id, eq); no need to sync irq before free -- pw-bot: cr