From: Simon Horman <horms@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David Ahern <dsahern@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] dev: Pass netdevice_tracker to dev_get_by_flags_rcu().
Date: Sat, 12 Jul 2025 11:27:02 +0100 [thread overview]
Message-ID: <20250712102702.GW721198@horms.kernel.org> (raw)
In-Reply-To: <20250711051120.2866855-1-kuniyu@google.com>
On Fri, Jul 11, 2025 at 05:10:59AM +0000, Kuniyuki Iwashima wrote:
> This is a follow-up for commit eb1ac9ff6c4a5 ("ipv6: anycast: Don't
> hold RTNL for IPV6_JOIN_ANYCAST.").
>
> We should not add a new device lookup API without netdevice_tracker.
>
> Let's pass netdevice_tracker to dev_get_by_flags_rcu() and rename it
> with netdev_ prefix to match other newer APIs.
>
> Note that we always use GFP_ATOMIC for netdev_hold() as it's expected
> to be called under RCU.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Link: https://lore.kernel.org/netdev/20250708184053.102109f6@kernel.org/
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> ---
> v2:
> * Use netdev_tracker for other places ipv6_sock_ac_join()
> * Fix func name for EXPORT_IPV6_MOD()
> * Update kdoc
>
> v1: https://lore.kernel.org/netdev/20250709190144.659194-1-kuniyu@google.com/
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-12 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 5:10 [PATCH v2 net-next] dev: Pass netdevice_tracker to dev_get_by_flags_rcu() Kuniyuki Iwashima
2025-07-12 10:27 ` Simon Horman [this message]
2025-07-15 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250712102702.GW721198@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).