From: Jakub Kicinski <kuba@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Mark Bloch <mbloch@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
Simon Horman <horms@kernel.org>, Cosmin Ratiu <cratiu@nvidia.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] devlink: move DEVLINK_ATTR_MAX-sized array off stack
Date: Mon, 14 Jul 2025 08:27:56 -0700 [thread overview]
Message-ID: <20250714082756.40ad644c@kernel.org> (raw)
In-Reply-To: <5ca43852-0586-4811-bc45-99e19232ce9d@nvidia.com>
On Sun, 13 Jul 2025 15:28:11 +0300 Carolina Jubran wrote:
> > Sure, testing it. Will update.
>
> I have tested and it looks good. Thanks!
Awesome, would you be willing to post the official patch?
Add my as "suggested-by" and with my sign off.
Most of the work here was the testing :)
> >> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/
> >> netlink/specs/devlink.yaml
> >> index 1c4bb0cbe5f0..3d75bc530b30 100644
> >> --- a/Documentation/netlink/specs/devlink.yaml
> >> +++ b/Documentation/netlink/specs/devlink.yaml
> >> @@ -1271,12 +1259,20 @@ doc: Partial family for Devlink.
> >> type: flag
> >> -
> >> name: dl-rate-tc-bws
> >> - subset-of: devlink
> >> + name-prefix: devlink-attr-
>
> Maybe use name-prefix: devlink-attr-rate-tc- instead?
Sounds good!
next prev parent reply other threads:[~2025-07-14 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 14:59 [PATCH] [v2] devlink: move DEVLINK_ATTR_MAX-sized array off stack Arnd Bergmann
2025-07-10 0:45 ` Jakub Kicinski
2025-07-10 7:58 ` Carolina Jubran
2025-07-13 12:28 ` Carolina Jubran
2025-07-14 15:27 ` Jakub Kicinski [this message]
2025-07-14 18:29 ` Carolina Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714082756.40ad644c@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).