netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	donald.hunter@gmail.com, shuah@kernel.org,
	kory.maincent@bootlin.com, maxime.chevallier@bootlin.com,
	sdf@fomichev.me, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields
Date: Mon, 14 Jul 2025 09:31:45 -0700	[thread overview]
Message-ID: <20250714093145.01d33070@kernel.org> (raw)
In-Reply-To: <5d8d0616-9cd0-4bf6-b571-e88e4364b35a@nvidia.com>

On Sun, 13 Jul 2025 17:05:12 +0300 Gal Pressman wrote:
> # Exception while handling defer / cleanup (callback 1 of 1)!
> # Defer Exception| Traceback (most recent call last):
> # Defer Exception|   File
> "/root/devel/linux/tools/testing/selftests/net/lib/py/ksft.py", line
> 154, in ksft_flush_defer
> # Defer Exception|     entry.exec_only()
> # Defer Exception|   File
> "/root/devel/linux/tools/testing/selftests/net/lib/py/utils.py", line
> 157, in exec_only
> # Defer Exception|     self.func(*self.args, **self.kwargs)
> # Defer Exception|   File
> "/root/devel/linux/tools/net/ynl/pyynl/lib/ynl.py", line 1106, in _op
> # Defer Exception|     return self._ops(ops)[0]
> # Defer Exception|            ^^^^^^^^^^^^^^
> # Defer Exception|   File
> "/root/devel/linux/tools/net/ynl/pyynl/lib/ynl.py", line 1062, in _ops
> # Defer Exception|     raise NlError(nl_msg)
> # Defer Exception| net.ynl.pyynl.lib.ynl.NlError: Netlink error: Invalid
> argument
> # Defer Exception| nl_len = 84 (68) nl_flags = 0x300 nl_type = 2
> # Defer Exception| 	error: -22
> # Defer Exception| 	extack: {'msg': 'hash field config is not
> symmetric', 'bad-attr': '.input-xfrm'}
> not ok 8 rss_api.test_rxfh_fields_set
> ok 9 rss_api.test_rxfh_fields_set_xfrm # SKIP no input-xfrm supported
> ok 10 rss_api.test_rxfh_fields_ntf
> # Totals: pass:8 fail:1 xfail:0 xpass:0 skip:1 error:0
> 
> Also, after the test runs I see inconsistency in the rxfh values:
> 
> $ cli.py --family ethtool --dump rss-get
>                 'tcp4': {'ip-src', 'ip-dst', 'l4-b-0-1', 'l4-b-2-3'},
> 
> $ ethtool -n eth2 rx-flow-hash tcp4
> TCP over IPV4 flows use these fields for computing Hash flow key:
> IP SA

Hmm.. I think what happens here is that the test changes the config 
so the subsequent runs will pass? Will fix.

  reply	other threads:[~2025-07-14 16:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  1:52 [PATCH net-next 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-11  1:52 ` [PATCH net-next 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-13 11:08   ` Gal Pressman
2025-07-14 16:15     ` Jakub Kicinski
2025-07-11  1:52 ` [PATCH net-next 02/11] selftests: drv-net: rss_api: factor out checking min queue count Jakub Kicinski
2025-07-11  1:52 ` [PATCH net-next 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-11  1:52 ` [PATCH net-next 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-14 22:19   ` Edward Cree
2025-07-14 22:28     ` Jakub Kicinski
2025-07-11  1:52 ` [PATCH net-next 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-13 11:10   ` Gal Pressman
2025-07-14 16:21     ` Jakub Kicinski
2025-07-15  6:32       ` Gal Pressman
2025-07-11  1:52 ` [PATCH net-next 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-13 11:10   ` Gal Pressman
2025-07-11  1:52 ` [PATCH net-next 07/11] selftests: drv-net: rss_api: test setting hashing key " Jakub Kicinski
2025-07-11  1:53 ` [PATCH net-next 08/11] netlink: specs: define input-xfrm enum in the spec Jakub Kicinski
2025-07-13 13:20   ` Gal Pressman
2025-07-11  1:53 ` [PATCH net-next 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-13 11:11   ` Gal Pressman
2025-07-14 16:27     ` Jakub Kicinski
2025-07-11  1:53 ` [PATCH net-next 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-13 11:12   ` Gal Pressman
2025-07-14 16:29     ` Jakub Kicinski
2025-07-15 10:27       ` Gal Pressman
2025-07-15 14:50         ` Jakub Kicinski
2025-07-11  1:53 ` [PATCH net-next 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
2025-07-13 14:05   ` Gal Pressman
2025-07-14 16:31     ` Jakub Kicinski [this message]
2025-07-13 11:06 ` [PATCH net-next 00/11] ethtool: rss: support RSS_SET via Netlink Gal Pressman
2025-07-14 16:35   ` Jakub Kicinski
2025-07-15  6:33     ` Gal Pressman
2025-07-15 14:53       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250714093145.01d33070@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).