[PATCH net] selftests: net: increase inter-packet timeout in udpgro.sh

[PATCH net] selftests: net: increase inter-packet timeout in udpgro.sh

[Paolo Abeni]

The mentioned test is not very stable when running on top of
debug kernel build. Increase the inter-packet timeout to allow
more slack in such environments.

Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 tools/testing/selftests/net/udpgro.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/udpgro.sh b/tools/testing/selftests/net/udpgro.sh
index 1dc337c709f8..b17e032a6d75 100755
--- a/tools/testing/selftests/net/udpgro.sh
+++ b/tools/testing/selftests/net/udpgro.sh
@@ -48,7 +48,7 @@ run_one() {
 
 	cfg_veth
 
-	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} &
+	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 100 ${rx_args} &
 	local PID1=$!
 
 	wait_local_port_listen ${PEER_NS} 8000 udp
@@ -95,7 +95,7 @@ run_one_nat() {
 	# will land on the 'plain' one
 	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -G ${family} -b ${addr1} -n 0 &
 	local PID1=$!
-	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${family} -b ${addr2%/*} ${rx_args} &
+	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 100 ${family} -b ${addr2%/*} ${rx_args} &
 	local PID2=$!
 
 	wait_local_port_listen "${PEER_NS}" 8000 udp
@@ -117,9 +117,9 @@ run_one_2sock() {
 
 	cfg_veth
 
-	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} -p 12345 &
+	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 100 ${rx_args} -p 12345 &
 	local PID1=$!
-	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 10 ${rx_args} &
+	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 100 ${rx_args} &
 	local PID2=$!
 
 	wait_local_port_listen "${PEER_NS}" 12345 udp
-- 
2.50.0

Re: [PATCH net] selftests: net: increase inter-packet timeout in udpgro.sh

[Simon Horman]

On Thu, Jul 10, 2025 at 06:04:50PM +0200, Paolo Abeni wrote:
> The mentioned test is not very stable when running on top of
> debug kernel build. Increase the inter-packet timeout to allow
> more slack in such environments.
> 
> Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

As I understand it, the motivation for this patch was to make
this test more resilient [1].

[1] [TEST] net/udpgro.sh is flaky on debug
    https://lore.kernel.org/netdev/20250710070907.33d11177@kernel.org/

My observation is that it has been used since the 10th.
And that there have been no failures since the 10th [2].

In slightly more detail. The last failure was now 4 days ago.
It occurred with net-next-2025-07-10--12-00 which did not include this patch.

[2] https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=u`dpgro-sh&ld_cnt=200&pass=0

So while it might be prudent to wait a few more days.
So far this gets my thumbs up.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net] selftests: net: increase inter-packet timeout in udpgro.sh

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 10 Jul 2025 18:04:50 +0200 you wrote:
> The mentioned test is not very stable when running on top of
> debug kernel build. Increase the inter-packet timeout to allow
> more slack in such environments.
> 
> Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> 
> [...]

Here is the summary with links:
  - [net] selftests: net: increase inter-packet timeout in udpgro.sh
    https://git.kernel.org/netdev/net/c/0e9418961f89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html