From: Jakub Kicinski <kuba@kernel.org>
To: Li Tian <litian@redhat.com>
Cc: netdev@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Long Li <longli@microsoft.com>
Subject: Re: [PATCH net v3] hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf
Date: Mon, 14 Jul 2025 18:32:42 -0700 [thread overview]
Message-ID: <20250714183242.58bf076f@kernel.org> (raw)
In-Reply-To: <20250712100716.3991-1-litian@redhat.com>
On Sat, 12 Jul 2025 18:07:08 +0800 Li Tian wrote:
> Set an additional flag IFF_NO_ADDRCONF to prevent ipv6 addrconf.
>
> Commit 8a321cf7becc
> ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")
This line looks quite odd, it's in the middle of the commit message but
it's not a real sentence. If there's a single Fixes tag I usually refer
to it as "commit under Fixes", e.g. "Commit under Fixes changed XYZ but
it missed .." Please make this commit message read like a coherent
explanation rather than set of notes..
> This new flag change was not made to hv_netvsc resulting in the VF being
> assinged an IPv6.
>
> Fixes: 8a321cf7becc ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")
--
pw-bot: cr
prev parent reply other threads:[~2025-07-15 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 10:07 [PATCH net v3] hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf Li Tian
2025-07-15 1:32 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714183242.58bf076f@kernel.org \
--to=kuba@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=litian@redhat.com \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).