From: Stanislav Fomichev <sdf@fomichev.me>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: [PATCH net-next v4 0/7] net: maintain netif vs dev prefix semantics
Date: Mon, 14 Jul 2025 15:18:48 -0700 [thread overview]
Message-ID: <20250714221855.3795752-1-sdf@fomichev.me> (raw)
Commit cc34acd577f1 ("docs: net: document new locking reality")
introduced netif_ vs dev_ function semantics: the former expects locked
netdev, the latter takes care of the locking. We don't strictly
follow this semantics on either side, but there are more dev_xxx handlers
now that don't fit. Rename them to netif_xxx where appropriate. We care only
about driver-visible APIs, don't touch stack-internal routines.
The rest seem to be ok:
* dev_xdp_prog_count - mostly called by sw drivers (bonding), should not matter
* dev_get_by_xxx - too many to reasonably cleanup, already have different flavors
* dev_fetch_sw_netstats - don't need instance lock
* dev_get_tstats64 - never called directly, only as an ndo callback
* dev_pick_tx_zero - never called directly, only as an ndo callback
* dev_add_pack / dev_remove_pack - called early enough (in module init) to not matter
* dev_get_iflink - mostly called by sw drivers, should not matter
* dev_fill_forward_path - ditto
* dev_getbyhwaddr_rcu - ditto
* dev_getbyhwaddr - ditto
* dev_getfirstbyhwtype - ditto
* dev_valid_name - ditto
* __dev_forward_skb dev_forward_skb dev_queue_xmit_nit - established helpers, no netif vs dev distinction
v4:
- drop dev_get_stats patch (Jakub)
- switch to ops-locked assert in netif_set_mtu_ext (Jakub)
- fix more docs (Jakub)
v3:
- move MODULE_IMPORT_NS closer to other module metadata (Willem)
- add MODULE_IMPORT_NS to bridge (build bot)
- add ops lock assert where appropriate (Willem)
- netif_close_many - calls __dev_close_many which has an assert
- netif_set_threaded - already has an assert
- netif_get_flags - READ_ONCE, does not need any locks
- netif_set_mtu_ext - added ops lock assert, updated the doc
- netif_get_mac_address - uses dev_addr_sem
- netif_get_port_parent_id - needs only rtnl?
- netif_get_stats - uses other mechanisms (seqlock)
v2:
- move a bunch of symbols into NETDEV_INTERNAL (Willem)
- netif_close_many
- __netif_set_mtu
- netif_pre_changeaddr_notify
- netif_get_mac_address
- keep more info in the individual patches' commit message (Willem)
Stanislav Fomichev (7):
net: s/dev_get_port_parent_id/netif_get_port_parent_id/
net: s/dev_get_mac_address/netif_get_mac_address/
net: s/dev_pre_changeaddr_notify/netif_pre_changeaddr_notify/
net: s/__dev_set_mtu/__netif_set_mtu/
net: s/dev_get_flags/netif_get_flags/
net: s/dev_set_threaded/netif_set_threaded/
net: s/dev_close_many/netif_close_many/
.../networking/net_cachelines/net_device.rst | 2 +-
drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
drivers/net/bonding/bond_main.c | 5 +-
.../net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +-
.../net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
drivers/net/ethernet/mellanox/mlxsw/pci.c | 2 +-
drivers/net/ethernet/renesas/ravb_main.c | 2 +-
drivers/net/ipvlan/ipvlan_main.c | 7 +-
drivers/net/tap.c | 5 +-
drivers/net/tun.c | 3 +-
drivers/net/wireguard/device.c | 2 +-
drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
fs/smb/server/smb2pdu.c | 2 +-
include/linux/netdevice.h | 17 ++--
net/8021q/vlan.c | 5 +-
net/bridge/br.c | 7 +-
net/bridge/br_if.c | 3 +-
net/bridge/br_netlink.c | 2 +-
net/bridge/br_switchdev.c | 2 +-
net/core/dev.c | 95 ++++++++++---------
net/core/dev_addr_lists.c | 2 +-
net/core/dev_api.c | 12 +++
net/core/dev_ioctl.c | 5 +-
net/core/net-sysfs.c | 6 +-
net/core/rtnetlink.c | 6 +-
net/dsa/dsa.c | 3 +-
net/dsa/user.c | 2 +-
net/ipv4/fib_frontend.c | 2 +-
net/ipv4/fib_semantics.c | 2 +-
net/ipv4/ipmr.c | 2 +-
net/ipv4/nexthop.c | 2 +-
net/ipv6/addrconf.c | 2 +-
net/mpls/af_mpls.c | 6 +-
net/wireless/wext-core.c | 2 +-
35 files changed, 128 insertions(+), 98 deletions(-)
--
2.50.0
next reply other threads:[~2025-07-14 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 22:18 Stanislav Fomichev [this message]
2025-07-14 22:18 ` [PATCH net-next v4 1/7] net: s/dev_get_port_parent_id/netif_get_port_parent_id/ Stanislav Fomichev
2025-07-14 22:18 ` [PATCH net-next v4 2/7] net: s/dev_get_mac_address/netif_get_mac_address/ Stanislav Fomichev
2025-07-14 22:18 ` [PATCH net-next v4 3/7] net: s/dev_pre_changeaddr_notify/netif_pre_changeaddr_notify/ Stanislav Fomichev
2025-07-14 22:18 ` [PATCH net-next v4 4/7] net: s/__dev_set_mtu/__netif_set_mtu/ Stanislav Fomichev
2025-07-14 22:18 ` [PATCH net-next v4 5/7] net: s/dev_get_flags/netif_get_flags/ Stanislav Fomichev
2025-07-14 22:18 ` [PATCH net-next v4 6/7] net: s/dev_set_threaded/netif_set_threaded/ Stanislav Fomichev
2025-07-15 23:36 ` Jakub Kicinski
2025-07-14 22:18 ` [PATCH net-next v4 7/7] net: s/dev_close_many/netif_close_many/ Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714221855.3795752-1-sdf@fomichev.me \
--to=sdf@fomichev.me \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).