From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
shuah@kernel.org, kory.maincent@bootlin.com,
maxime.chevallier@bootlin.com, sdf@fomichev.me,
ecree.xilinx@gmail.com, gal@nvidia.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 07/11] selftests: drv-net: rss_api: test setting hashing key via Netlink
Date: Mon, 14 Jul 2025 15:27:25 -0700 [thread overview]
Message-ID: <20250714222729.743282-8-kuba@kernel.org> (raw)
In-Reply-To: <20250714222729.743282-1-kuba@kernel.org>
Test setting hashing key via Netlink.
# ./tools/testing/selftests/drivers/net/hw/rss_api.py
TAP version 13
1..7
ok 1 rss_api.test_rxfh_nl_set_fail
ok 2 rss_api.test_rxfh_nl_set_indir
ok 3 rss_api.test_rxfh_nl_set_indir_ctx
ok 4 rss_api.test_rxfh_indir_ntf
ok 5 rss_api.test_rxfh_indir_ctx_ntf
ok 6 rss_api.test_rxfh_nl_set_key
ok 7 rss_api.test_rxfh_fields
# Totals: pass:7 fail:0 xfail:0 xpass:0 skip:0 error:0
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
| 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
--git a/tools/testing/selftests/drivers/net/hw/rss_api.py b/tools/testing/selftests/drivers/net/hw/rss_api.py
index 07079da6a311..4de566edb313 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_api.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_api.py
@@ -6,6 +6,7 @@ API level tests for RSS (mostly Netlink vs IOCTL).
"""
import glob
+import random
from lib.py import ksft_run, ksft_exit, ksft_eq, ksft_is, ksft_ne, ksft_raises
from lib.py import KsftSkipEx, KsftFailEx
from lib.py import defer, ethtool, CmdExitFailure
@@ -199,6 +200,38 @@ from lib.py import NetDrvEnv
ksft_eq(set(ntf["msg"]["indir"]), {1})
+def test_rxfh_nl_set_key(cfg):
+ """
+ Test setting hashing key via Netlink.
+ """
+
+ dflt = cfg.ethnl.rss_get({"header": {"dev-index": cfg.ifindex}})
+ defer(cfg.ethnl.rss_set,
+ {"header": {"dev-index": cfg.ifindex},
+ "hkey": dflt["hkey"], "indir": None})
+
+ # Empty key should error out
+ with ksft_raises(NlError) as cm:
+ cfg.ethnl.rss_set({"header": {"dev-index": cfg.ifindex},
+ "hkey": None})
+ ksft_eq(cm.exception.nl_msg.extack['bad-attr'], '.hkey')
+
+ # Set key to random
+ mod = random.randbytes(len(dflt["hkey"]))
+ cfg.ethnl.rss_set({"header": {"dev-index": cfg.ifindex},
+ "hkey": mod})
+ rss = cfg.ethnl.rss_get({"header": {"dev-index": cfg.ifindex}})
+ ksft_eq(rss.get("hkey", [-1]), mod)
+
+ # Set key to random and indir tbl to something at once
+ mod = random.randbytes(len(dflt["hkey"]))
+ cfg.ethnl.rss_set({"header": {"dev-index": cfg.ifindex},
+ "indir": [0, 1], "hkey": mod})
+ rss = cfg.ethnl.rss_get({"header": {"dev-index": cfg.ifindex}})
+ ksft_eq(rss.get("hkey", [-1]), mod)
+ ksft_eq(set(rss.get("indir", [-1])), {0, 1})
+
+
def test_rxfh_fields(cfg):
"""
Test reading Rx Flow Hash over Netlink.
--
2.50.1
next prev parent reply other threads:[~2025-07-14 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 22:27 [PATCH net-next v2 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-15 7:20 ` Gal Pressman
2025-07-15 14:39 ` Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 02/11] selftests: drv-net: rss_api: factor out checking min queue count Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-15 7:24 ` Gal Pressman
2025-07-14 22:27 ` [PATCH net-next v2 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-15 7:30 ` Gal Pressman
2025-07-14 22:27 ` Jakub Kicinski [this message]
2025-07-14 22:27 ` [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec Jakub Kicinski
2025-07-15 8:35 ` Gal Pressman
2025-07-15 14:45 ` Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-15 8:40 ` Gal Pressman
2025-07-14 22:27 ` [PATCH net-next v2 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714222729.743282-8-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).