From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
donald.hunter@gmail.com, shuah@kernel.org,
kory.maincent@bootlin.com, maxime.chevallier@bootlin.com,
sdf@fomichev.me, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec
Date: Tue, 15 Jul 2025 07:45:34 -0700 [thread overview]
Message-ID: <20250715074534.30783870@kernel.org> (raw)
In-Reply-To: <7fe0c573-4a4d-4cff-a1c2-9d4638eea3e1@nvidia.com>
On Tue, 15 Jul 2025 11:35:08 +0300 Gal Pressman wrote:
> We kinda use input_xfrm as an enum, but in theory it's a bitmask, so
> while this is OK today, I'm not sure this patch is future-proof.
Yeah, a little unclear at this stage if it's a bitmask or an enum since
we only have values 0 1 2 defined, and the defined values cannot be
composed. Adding an entry that'd compose would be painful if we go with
the string. OTOH I can't think of any composable transform and it's
extra effort to extract the entry form a one-element set each time.
I guess we should go with future-proofness when in doubt.
I'll make it into flags in v3.
next prev parent reply other threads:[~2025-07-15 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 22:27 [PATCH net-next v2 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-15 7:20 ` Gal Pressman
2025-07-15 14:39 ` Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 02/11] selftests: drv-net: rss_api: factor out checking min queue count Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-15 7:24 ` Gal Pressman
2025-07-14 22:27 ` [PATCH net-next v2 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-15 7:30 ` Gal Pressman
2025-07-14 22:27 ` [PATCH net-next v2 07/11] selftests: drv-net: rss_api: test setting hashing key " Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec Jakub Kicinski
2025-07-15 8:35 ` Gal Pressman
2025-07-15 14:45 ` Jakub Kicinski [this message]
2025-07-14 22:27 ` [PATCH net-next v2 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-15 8:40 ` Gal Pressman
2025-07-14 22:27 ` [PATCH net-next v2 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-14 22:27 ` [PATCH net-next v2 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715074534.30783870@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).