From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
donald.hunter@gmail.com, shuah@kernel.org,
kory.maincent@bootlin.com, maxime.chevallier@bootlin.com,
sdf@fomichev.me, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 10/11] ethtool: rss: support setting flow hashing fields
Date: Tue, 15 Jul 2025 07:50:38 -0700 [thread overview]
Message-ID: <20250715075038.6d37812a@kernel.org> (raw)
In-Reply-To: <7bfc8766-0f6f-4309-984e-24ef86f5c8e3@nvidia.com>
On Tue, 15 Jul 2025 13:27:51 +0300 Gal Pressman wrote:
> > IOCTL has two separate calls for this so there's no way to even try
> > to change both at once. I'll add "unlike IOCTL which has separate
> > calls" ?
>
> So it's different because you can use netlink directly to change both,
> but from userspace ethtool perspective there's no difference, right?
> It's still two commands.
Yup! The existing CLI will likely stay as is.
> Makes sense, thanks for the explanation.
>
> >> Why not use mod?
> >
> > Because it's a difference driver-facing op.
>
> Why do we need to differentiate where the mod originated? We have a
> single return value.
Right, but if we only modified the indirection table there's no need
to call the driver to update the hashing fields and vice versa.
To be clear this is just "an optimization", doesn't affect correctness
in any way.
next prev parent reply other threads:[~2025-07-15 14:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 1:52 [PATCH net-next 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-11 1:52 ` [PATCH net-next 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-13 11:08 ` Gal Pressman
2025-07-14 16:15 ` Jakub Kicinski
2025-07-11 1:52 ` [PATCH net-next 02/11] selftests: drv-net: rss_api: factor out checking min queue count Jakub Kicinski
2025-07-11 1:52 ` [PATCH net-next 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-11 1:52 ` [PATCH net-next 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-14 22:19 ` Edward Cree
2025-07-14 22:28 ` Jakub Kicinski
2025-07-11 1:52 ` [PATCH net-next 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-13 11:10 ` Gal Pressman
2025-07-14 16:21 ` Jakub Kicinski
2025-07-15 6:32 ` Gal Pressman
2025-07-11 1:52 ` [PATCH net-next 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-13 11:10 ` Gal Pressman
2025-07-11 1:52 ` [PATCH net-next 07/11] selftests: drv-net: rss_api: test setting hashing key " Jakub Kicinski
2025-07-11 1:53 ` [PATCH net-next 08/11] netlink: specs: define input-xfrm enum in the spec Jakub Kicinski
2025-07-13 13:20 ` Gal Pressman
2025-07-11 1:53 ` [PATCH net-next 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-13 11:11 ` Gal Pressman
2025-07-14 16:27 ` Jakub Kicinski
2025-07-11 1:53 ` [PATCH net-next 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-13 11:12 ` Gal Pressman
2025-07-14 16:29 ` Jakub Kicinski
2025-07-15 10:27 ` Gal Pressman
2025-07-15 14:50 ` Jakub Kicinski [this message]
2025-07-11 1:53 ` [PATCH net-next 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
2025-07-13 14:05 ` Gal Pressman
2025-07-14 16:31 ` Jakub Kicinski
2025-07-13 11:06 ` [PATCH net-next 00/11] ethtool: rss: support RSS_SET via Netlink Gal Pressman
2025-07-14 16:35 ` Jakub Kicinski
2025-07-15 6:33 ` Gal Pressman
2025-07-15 14:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715075038.6d37812a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).