From: Jakub Kicinski <kuba@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
Donald Hunter <donald.hunter@gmail.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Ralf Lici <ralf@mandelbit.com>
Subject: Re: [PATCH net 2/3] ovpn: explicitly reject netlink attr PEER_LOCAL_PORT in CMD_PEER_NEW/SET
Date: Tue, 15 Jul 2025 08:06:30 -0700 [thread overview]
Message-ID: <20250715080630.2704593e@kernel.org> (raw)
In-Reply-To: <d063c580-9e52-4f2b-ada2-7ca097cb9b85@openvpn.net>
On Tue, 15 Jul 2025 16:36:40 +0200 Antonio Quartulli wrote:
> As Jakub predicted, I am hitting a problem with PEER_GET: the
> attribute-set is one for the entire op, therefore I can't specify two
> different sets for request and reply.
>
> I presume I need to leave PEER_GET on the main 'ovpn' set and then
> opencode the restriction of having only the ID in the request.
>
> Similarly goes for KEY_GET.
>
> Sabrina, Jakub, does it make sense to you?
Yes :( Sorry for the mixed solution but I think using the spec to its
full capabilities is worthwhile, even if it doesn't cover all the needs.
next prev parent reply other threads:[~2025-07-15 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:45 [PATCH net 0/3] pull request: ovpn for net 2025-07-03 Antonio Quartulli
2025-07-03 11:45 ` [PATCH net 1/3] ovpn: propagate socket mark to skb in UDP Antonio Quartulli
2025-07-03 14:02 ` Sabrina Dubroca
2025-07-03 11:45 ` [PATCH net 2/3] ovpn: explicitly reject netlink attr PEER_LOCAL_PORT in CMD_PEER_NEW/SET Antonio Quartulli
2025-07-03 13:07 ` Sabrina Dubroca
2025-07-07 21:48 ` Jakub Kicinski
2025-07-08 10:20 ` Sabrina Dubroca
2025-07-08 14:47 ` Jakub Kicinski
2025-07-13 20:04 ` Antonio Quartulli
2025-07-14 14:56 ` Jakub Kicinski
2025-07-15 14:36 ` Antonio Quartulli
2025-07-15 15:06 ` Jakub Kicinski [this message]
2025-07-15 15:08 ` Antonio Quartulli
2025-07-03 11:45 ` [PATCH net 3/3] ovpn: reset GSO metadata after decapsulation Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715080630.2704593e@kernel.org \
--to=kuba@kernel.org \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).